Added a section explaining how slicing reads are handled #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
reviewed
Dec 8, 2021
cpcloud
requested changes
Dec 8, 2021
|
@westonpace , can you rebase? |
a28dc81
to
e9f3a8d
Compare
|
@jacques-n rebased |
Reworded it so that the chunk deciding behavior is optional Added some information to the proto file Added some information to the proto file Markdown table formatting
c059f52
to
9e3ca4a
Compare
jacques-n
approved these changes
Feb 7, 2022
rkondakov
pushed a commit
to rkondakov/substrait
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added based on the discussion here: #102 (comment)