You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but a test should be added for the second point once the first point is fixed
i would have fixed it, but i don’t have the slightest idea what all the “multicolumn” fields are for. also i don’t believe in too many caches and private fields, they get out of sync too easily. recomputing tiny things is fast, e.g. self._keys could simply be replaced with self.dtype.names
The text was updated successfully, but these errors were encountered:
struct_dict['k']
should return a simple 1D ndarray, not aStructDict
struct_dict[['a', 'b']]
should return a properStructDict
including all additional fields like_keys
both problems are visible in this test: https://travis-ci.org/theislab/scanpy/jobs/227216146#L224
but a test should be added for the second point once the first point is fixed
i would have fixed it, but i don’t have the slightest idea what all the “multicolumn” fields are for. also i don’t believe in too many caches and private fields, they get out of sync too easily. recomputing tiny things is fast, e.g.
self._keys
could simply be replaced withself.dtype.names
The text was updated successfully, but these errors were encountered: