[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rank_genes_groups_gene_names is no longer here. #392

Closed
flying-sheep opened this issue Dec 7, 2018 · 2 comments
Closed

rank_genes_groups_gene_names is no longer here. #392

flying-sheep opened this issue Dec 7, 2018 · 2 comments

Comments

@flying-sheep
Copy link
Member
flying-sheep commented Dec 7, 2018

correlation_matrix:

https://github.com/theislab/scanpy/blob/21adc0c9a31fb1eebb16579aa4f41700bc939aa2/scanpy/tools/top_genes.py#L58

exploratory_rank_analysis:

https://github.com/theislab/scanpy/blob/02e78bb025f9cd8d02cf6d39256fea008ec51d7f/scanpy/plotting/top_genes_visual.py#L109

also correlation_matrix is not included in the docs, and the recommendations alex made on 573519e aren’t implemented.

generally, please don’t just commit low quality and unfinished code to master @tcallies. that’s what PRs are for.

@falexwolf
Copy link
Member

Both of these modules are not in the docs and not referenced in any tutorial and I never considered them mature code... I always planned on fixing these... but my bandwidth for this is limited...

I should not have merged them into master, that's my fault... Won't happen again...

@flying-sheep
Copy link
Member Author

Oh, there was a PR? I missed that. I thought it was just committed directly to master.

I think it’s even OK to merge in unstable functions as long as we don’t reexport them in scanpy.api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants