-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Better input and output folder names #1315
Comments
I like this idea a lot, but would suggest a small tweak: maybe (sorry if this is too bikesheddy, if you don't immediately agree that either suggestion is an improvement, feel free to disregard). |
Happy to have it changed, though will need to update in a fair few places: https://github.com/search?q=repo%3Asphinx-gallery%2Fsphinx-gallery%20auto_example&type=code Input: Preference for something short, Output: The new URL is nice but I wonder if it would cause confusion if someone was e.g., looking at how SG is setup in an existing project? |
I like
Just checked the output folder: Looking at |
Thanks for doing the numbers, I'm okay with the change. @larsoner WDYT? |
Side notes:
|
When I started working on SG the names I agree the names could be improved but it would be a backwards incompatible change, which we tend not to do. @larsoner ? |
Well I suppose we're on the topic well enough... Agreed we don't want to break existing code for this. But taking @timhoffm's hint about backward compat we could for example allow aliases, like you either specify the pair As a side point, I think the current naming stems from the projects having existing |
The current docs describle the following folder layout and config:
I find this not ideal for the following reasons.
examples
) is at the top level in the project. I rather see it as part of the documentation, so it should be indocs
.examples
does not give any hint that this is input.auto_example
is descriptive on how this is generated, its irrelevant for the user of the docs.htttps://myproject.org/examples/hello_world.html
reads much better thanhttps://myproject.org/auto_examples/hello_world.html
.I thus propose to place both folders under
docs
and name the ouput folderexamples
and name the input folderexamples_inputs
, i.e.If you agree with the change, I can make a PR.
The text was updated successfully, but these errors were encountered: