[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks from exapmple app #677

Open
no1seman opened this issue Jan 18, 2022 · 1 comment
Open

Remove checks from exapmple app #677

no1seman opened this issue Jan 18, 2022 · 1 comment
Labels
needs investigation

Comments

@no1seman
Copy link
no1seman commented Jan 18, 2022 •
edited
Loading

Why need to point

cartridge-cli/examples/getting-started-app/getting-started-app-scm-1.rockspec

Line 10 in 8c642c7

'checks == 3.1.0-1',
in app rockspec when cartridge have checks as a dependency?

Seems need to remove, because when later user upgrades for examaple Cartridge version it may have later version of checks and on build/pack there are warnigs about multiple version which confusing.
@no1seman no1seman changed the title Remove chacks from exapmple app Remove checks from exapmple app Jan 20, 2022
@Totktonada
Copy link
Member
Totktonada commented Feb 2, 2022 •
edited
Loading

As result some (latest? random?) version of a dependency is used everywhere. I think that it should be handled on luarocks make/install level.

Fixed dependencies is okay for an application. But we possibly should have relaxed dependencies in modules.

@kyukhin kyukhin added the teamE label Feb 11, 2022
@TarantoolBot TarantoolBot removed the teamE label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Totktonada @kyukhin @no1seman @TarantoolBot