[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in example output #5

Closed
jdeligt opened this issue Feb 29, 2020 · 4 comments
Closed

Discrepancy in example output #5

jdeligt opened this issue Feb 29, 2020 · 4 comments
Labels

Comments

@jdeligt
Copy link
jdeligt commented Feb 29, 2020

I installed through conda and ran covtobed -m 0 -x 5 test/demo.bam on the git repo;

EMPTY 0 414 0
NC_001416.1 0 2 0
NC_001416.1 2 6 1
NC_001416.1 6 7 2
NC_001416.1 7 12 3
NC_001416.1 12 18 4
NC_001416.1 169 170 4
NC_001416.1 201 206 4
NC_001416.1 206 207 3
NC_001416.1 207 214 4
NC_001416.1 514 539 4
NC_001416.1 539 540 3
NC_001416.1 540 569 4
NC_001416.1 596 609 4
NC_001416.1 1120 1999 0
NC_001416.1 2653 2674 4
NC_001416.1 2674 2686 3
NC_001416.1 2686 2762 2
NC_001416.1 2762 2771 1
NC_001416.1 2771 2800 0

Please update the example to match what is in the repo.

@telatin
Copy link
Owner
telatin commented Mar 2, 2020

To keep the README short, I explicited the truncation with [...].

@telatin telatin closed this as completed Mar 2, 2020
@telatin telatin added the joss label Mar 2, 2020
@jdeligt
Copy link
Author
jdeligt commented Mar 2, 2020

Thanks for updating it, I was mainly referring to a line that is not just missing but discordant;

Original

NC_001416.1 1112 1120 4
NC_001416.1 1120 1999 0

Actual

NC_001416.1 596 609 4
NC_001416.1 1120 1999 0

This suggests that data has changed in the repo without the Readme being updated accordingly.
Or that functionaility changed, adding a test folder with the test output generated with the data and code in the repo can prevent things like that from happening.
I see that you have started a README in the test output. Please include the full test output and potential output files from example commaands here and populate it with a test suite or script.

@telatin
Copy link
Owner
telatin commented Mar 2, 2020

I added new synthetic BAM files to allow for automated tests. In particular "test_cov.bam" has reference chromosomes named after the coverage of the only peak expected (e.g. reference 5X is expected to produce a single BED feature of 5X coverage).

https://github.com/telatin/covtobed/wiki/Testing

@jdeligt
Copy link
Author
jdeligt commented Mar 2, 2020

All good, missed that, sorry. Thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants