[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Documentation for MetricConfig #134

Open
sumitbinnani opened this issue Jul 12, 2021 · 0 comments
Open

Incorrect Documentation for MetricConfig #134

sumitbinnani opened this issue Jul 12, 2021 · 0 comments
Assignees
@mdreves
Labels
stat:awaiting tensorflower type:bug type:docs

Comments

@sumitbinnani
Copy link
sumitbinnani commented Jul 12, 2021 •
edited
Loading

Describe the problem

It seems like the config does not rely on the __init__ method; and relies on the get_config and from_config method of the (custom) metrics class.

This distinction is important as TFX's Evaluator serialize and deserialize the metric and __init__ is not used during the final metrics evaluation. Not sure if the issue should be raised with TFX or TFMA.

model-analysis/tensorflow_model_analysis/proto/config.proto

Lines 407 to 414 in 4ea7d16

// Optional JSON encoded config settings associated with the class.
//
// The config settings will be passed as **kwarg values to the __init__ method
// for the class. For ease of use the leading and trailing '{' and '}'
// brackets may be omitted.
//
// Example: '"name": "my_metric", "thresholds": [0.5]'
string config = 3;

Link to TFX Issue: tensorflow/tfx#4022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdreves mdreves

Labels
stat:awaiting tensorflower type:bug type:docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdreves @sumitbinnani @arghyaganguly