[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to sympy v 1.7 #589

Closed
simonwa7 opened this issue Jun 7, 2021 · 4 comments · Fixed by #591
Closed

Upgrade to sympy v 1.7 #589

simonwa7 opened this issue Jun 7, 2021 · 4 comments · Fixed by #591
Assignees
@MichaelBroughton

Comments

@simonwa7
Copy link
simonwa7 commented Jun 7, 2021

Hi all!

I was wondering if there were any plans to upgrade tfq to be compatible with the newer versions of sympy? I am currently working on a project that requires sympy>=1.7, but I see there is a strict requirement on sympy==1.5 within the requirements.txt. I am hoping to work with tensorflow-quantum, but I am currently blocked by this compatibility issue.

Happy to help in any way that I can!

Thanks!
@MichaelBroughton MichaelBroughton self-assigned this Jun 8, 2021
@MichaelBroughton
Copy link
Collaborator
MichaelBroughton commented Jun 8, 2021 •
edited
Loading

Hi @simonwa7 thanks for raising the issue.

This is absolutely something we can work on and probably get done pretty quick.

I'll look into this later this week.

@jaeyoo I have this faint memory of us choosing sympy 1.5 because it behaved better when serializing (particularly with rounding and strange numpy interactions ??? ), do you remember if there were any other reasons we locked onto 1.5 ?

Possibly also useful #423

@jaeyoo
Copy link
Member
jaeyoo commented Jun 8, 2021

Hmm i don't remember it. l am pretty open to upgrade to Sympy 1.7.

@simonwa7
Copy link
Author
simonwa7 commented Jun 8, 2021

Thank you @MichaelBroughton and @jaeyoo :) This is really helpful!

@MichaelBroughton MichaelBroughton mentioned this issue Jun 11, 2021
Merged
@MichaelBroughton
Copy link
Collaborator

This should now appear in the latest tfq-nightly install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelBroughton MichaelBroughton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgraded sympy to v1.8. tensorflow/quantum
3 participants
@MichaelBroughton @simonwa7 @jaeyoo