[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] js_func (for javascript) equivalent of py_func #18280

Open
cancan101 opened this issue Apr 5, 2018 · 7 comments
Open

[feature] js_func (for javascript) equivalent of py_func #18280

cancan101 opened this issue Apr 5, 2018 · 7 comments
Assignees
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower type:feature Feature requests

Comments

@cancan101
Copy link
Contributor
cancan101 commented Apr 5, 2018

System information

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
    n/a
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
    iOS, Android
  • TensorFlow installed from (source or binary):
    n/a
  • TensorFlow version (use command below):
    n/a
  • Python version:
    n/a
  • Bazel version (if compiling from source):
    n/a
  • GCC/Compiler version (if compiling from source):
    n/a
  • CUDA/cuDNN version:
    n/a
  • GPU model and memory:
    n/a
  • Exact command to reproduce:
    n/a

Describe the problem

I suggest adding a js_func that allows defining nodes in javascript. This would be similar to the existing py_func. There are many systems (ie iOS and Android) that have JS runtimes but do not have python runtimes.

@tensorflowbutler tensorflowbutler added the stat:awaiting response Status - Awaiting response from author label Apr 6, 2018
@tensorflowbutler
Copy link
Member

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

@reedwm
Copy link
Member
reedwm commented Apr 6, 2018

/CC @dsmilkov, can you take a look at this proposal?

@reedwm reedwm added the type:feature Feature requests label Apr 6, 2018
@reedwm reedwm assigned dsmilkov and unassigned reedwm Apr 6, 2018
@dsmilkov
Copy link
Contributor
dsmilkov commented Apr 11, 2018

Hi @cancan101, the body of the py_func will not be serialized in a GraphDef. Therefore, you should not use this function if you need to serialize your model and restore it in a different environment.

Also, if you are using TensorFlow.js for development and thinking about this in a JS-only context, would you mind re-posting this issue to the tensorflow/tfjs issues?

Thanks!

@cancan101
Copy link
Contributor Author

Interesting to know that the body is not serialized; I had not realized that. I was not thinking of js_func in the context of tfjs. Rather I was thinking of loading a graph on iOS or Android and using the js_func to supply user created functions.

@dsmilkov dsmilkov removed their assignment Apr 11, 2018
@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Apr 12, 2018
@reedwm
Copy link
Member
reedwm commented Apr 13, 2018

/CC @andrewharp can you take a look since this is desired in mobile?

@reedwm reedwm assigned andrewharp and unassigned reedwm Apr 13, 2018
@chunduriv chunduriv added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label May 26, 2022
@tilakrayal
Copy link
Contributor

@cancan101,
Please let me know if my understanding is correct here. Looks like this isssue is more related to TensorFlow JavaScript, if you are using TensorFlow.js for development and thinking about this in a Javascript context, could you please try to post this issue to the tensorflow/tfjs issues

Thank you!

@tilakrayal tilakrayal added the stat:awaiting response Status - Awaiting response from author label May 21, 2024
@cancan101
Copy link
Contributor Author

No, this is not a tfjs issue. This is about the ability to have a node that can run javascript, similar to the py_func node that runs python code.

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

7 participants