[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move autograph into a separate package and into a separate repo #23601

Open
KOLANICH opened this issue Nov 8, 2018 · 12 comments
Open

Move autograph into a separate package and into a separate repo #23601

KOLANICH opened this issue Nov 8, 2018 · 12 comments
Assignees
Labels
comp:autograph Autograph related issues stat:awaiting tensorflower Status - Awaiting response from tensorflower type:feature Feature requests WIP

Comments

@KOLANICH
Copy link
KOLANICH commented Nov 8, 2018

System information

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): any
  • Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: n/a
  • TensorFlow installed from (source or binary): any
  • TensorFlow version (use command below): any
  • Python version: any
  • Bazel version (if compiling from source): any
  • GCC/Compiler version (if compiling from source): any
  • CUDA/cuDNN version: any
  • GPU model and memory: any
  • Exact command to reproduce: n/a

Describe the problem

I guess autograph should be moved into a separate package and repo. Because I guess it may be possible to add support of other computation graph frameworks there.

@Harshini-Gadige Harshini-Gadige added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Nov 19, 2018
@mdanatg
Copy link
mdanatg commented Nov 19, 2018

Indeed, and we plan to do that very soon. Due to time constraints, we've initially moved it inside TF core, and from there we'll extract the reusable parts into a standalone repo. We hope to have that set up by the end of this year.

@mdanatg mdanatg added WIP and removed stat:awaiting tensorflower Status - Awaiting response from tensorflower labels Nov 19, 2018
@chunduriv chunduriv self-assigned this Jun 3, 2022
@chunduriv chunduriv added the comp:autograph Autograph related issues label Jun 3, 2022
@chunduriv
Copy link
Contributor

@KOLANICH,

Sorry for the late response. The autograph moved to a new repo and it can be accessed as tf.autograph. Thank you.

@chunduriv chunduriv added the stat:awaiting response Status - Awaiting response from author label Jun 3, 2022
@KOLANICH
Copy link
Author
KOLANICH commented Jun 3, 2022

Thank you, and everyone involved into it. 🎉

@KOLANICH KOLANICH closed this as completed Jun 3, 2022
@KOLANICH KOLANICH reopened this Jun 3, 2022
@KOLANICH
Copy link
Author
KOLANICH commented Jun 3, 2022

The autograph moved to a new repo and it can be accessed as tf.autograph. Thank you.

It hasn't been moved to a new repo:

This repository contains tests and example code

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Jun 3, 2022
@chunduriv chunduriv added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Jun 3, 2022
@mdanatg
Copy link
mdanatg commented Jun 3, 2022

Yes, this is still an open issue (I think @chunduriv was referring to autograph being available in its own namespace). Mainly because we need someone to set up and maintain a separate repo - otherwise, significant parts of the source code (tensorflow/python/autograph/pyct) are already independent of TF and could be mover rather mechanically.

@mdanatg mdanatg removed their assignment Feb 7, 2023
@rmshaffer
Copy link
rmshaffer commented Jul 17, 2023

Commenting here for visibility. We have made a static copy of the autograph codebase for use in a framework which builds on autograph to convert Python functions into OpenQASM programs for quantum computations. We did not want to take a dependency on TensorFlow, so the quickest path forward was copying the codebase and making minor modifications to decouple it from TensorFlow. We would be very interested in consuming autograph as a standalone package, if it ever becomes available, and would be happy to help validate the work with our use case.

Here is our copy of the autograph codebase:
https://github.com/aws/amazon-braket-sdk-python/tree/feature/autoqasm/src/braket/experimental/autoqasm/autograph

More details on how we are using it:
https://github.com/aws/amazon-braket-sdk-python/blob/feature/autoqasm/src/braket/experimental/autoqasm/README.md

@josh146
Copy link
josh146 commented Sep 6, 2023

Hey all, having autograph available as a separate repo would also be super valuable/important from our end. We're in a similar position to @rmshaffer -- we're depending on Autograph in Catalyst, but don't want to have to depend on the full TensorFlow installation for users of our package.

Would it be possible to split autograph out -- without the TensorFlow dependency -- into its own PyPI package? We would be very happy to help out here :)

@mdanatg
Copy link
mdanatg commented Sep 7, 2023

It's certainly possible to split it out - autograph was designed with that in mind. Besides some dependencies in the high level API that accumulated as technical debt and should be easy to remove, only the operators are TF-specific, so as long as you have replacement for those (which I suspect you want anyway), a split should definitely be doable.

I'm not sure if there are any concrete plans to do such a split, so I'd recommend taking the lead and doing it.

@dime10
Copy link
dime10 commented Nov 23, 2023

Hello TensorFlow maintainers, I'm currently tackling the separation of TensorFlow and AutoGraph as a contribution to TF.

I have a question regarding the preferred code organization, for which I could see the following options:

  • keep all code within the tensorflow repo, while separating out build & packaging processes etc.
    • Following this model, either of the below could still be taken as a follow up.
  • keep all code within the tensorflow repo (as above), but also make a mirror available in a separate repository
    • I believe this was the model followed by mlir-hlo, although that code has now moved from tensorflow to xla.
  • move everything to a different repository, for instance the existing autograph repository

@mdanatg
Copy link
mdanatg commented Dec 1, 2023

I think the last option makes most sense, at least in the long run, although a clean move would not be easy to achieve. It would probably be most practical to start with a fork, and continue improvements there, while in parallel configuring TF for an external dependency.

@tilakrayal
Copy link
Contributor

Hi,

Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.

The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.

Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.

@tilakrayal tilakrayal added the stat:awaiting response Status - Awaiting response from author label May 17, 2024
@dime10
Copy link
dime10 commented May 20, 2024

Hi @tilakrayal, thank you for checking in. I don't think the latest TensorFlow release is resolving this issue, which is about separately packaging and releasing one of the sub-components of TensorFlow.

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label May 20, 2024
@tilakrayal tilakrayal added the type:feature Feature requests label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:autograph Autograph related issues stat:awaiting tensorflower Status - Awaiting response from tensorflower type:feature Feature requests WIP
Projects
None yet
Development

No branches or pull requests

8 participants