[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing initial_epoch parameter to callbacks' self.params in tf.keras.model.fit #39839

Open
shun-lin opened this issue May 24, 2020 · 0 comments
Assignees
Labels
comp:keras Keras related issues stat:awaiting tensorflower Status - Awaiting response from tensorflower type:feature Feature requests

Comments

@shun-lin
Copy link

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template

System information

  • TensorFlow version (you are using): 2.x
  • Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.

TensorFlow Addons are developing a progress bar (TQDM Progress bar) and we receive and issue where when user specify initialEpoch > 0 during model.fit and when using tfa.callbacks.TQDMProgressBar the progress bar will never reach 100% because in TQDMProgressBar code we never consider the case when user set initialEpoch

model.fit(x=X, y=y, class_weight=None, batch_size=batchSize, verbose=0, callbacks=tfa.callbacks.TQDMProgressBar(), validation_split=0.2, shuffle=True, epochs=epochCount, initial_epoch=initialEpoch)

tensorflow/addons#1748

While searching for a solution, I noticed that initial_epoch is never passed to Callback's self.params dictionary and thus making it hard to implement the feature where users set an initial epoch, thus I am asking if it would make sense for TensorFlow to pass initial_epoch to Callback's self.params for us to implement that feature. The other way around would be to ask user to specify initial_epoch again in the progress bar but that would not be ideal. Thank you so much for your time!

Will this change the current api? How?

No, but this will add another key into Callbacks' self.params dictionary.

Who will benefit with this feature?

Users of TensorFlow Addons TQDM Progress Bar and thus that may need initial_epoch in their custom callbacks.

Any Other info.

TensorFlow Addons TQDM Progress Bar Source code:
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/callbacks/tqdm_progress_bar.py

@shun-lin shun-lin added the type:feature Feature requests label May 24, 2020
@Saduf2019 Saduf2019 added the comp:keras Keras related issues label May 25, 2020
@jvishnuvardhan jvishnuvardhan added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:keras Keras related issues stat:awaiting tensorflower Status - Awaiting response from tensorflower type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

4 participants