[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Module support #39378

Open
cowwoc opened this issue May 10, 2020 · 11 comments
Open

Java Module support #39378

cowwoc opened this issue May 10, 2020 · 11 comments
Assignees
Labels
type:build/install Build and install issues type:feature Feature requests

Comments

@cowwoc
Copy link
cowwoc commented May 10, 2020

Describe the problem
Applications using Java9+ benefit from libraries have Java Module (JPMS) support. This comes in two stages:

  1. Ideally, add module-info.java to the library. Either publish a separate artifact for Java9+ or simply add META-INF/versions/9/module-info.class to support both versions simultaneously (multi-release jar)
  2. If the library has split packages, you cannot add module-info.java yet in which case you can simply add Automatic-Module-Name to the manifest file and begin resolving the split package issue.
@cowwoc cowwoc added the type:build/install Build and install issues label May 10, 2020
@ravikyram ravikyram assigned gowthamkpr and unassigned ravikyram May 11, 2020
@gowthamkpr gowthamkpr assigned sjamesr and unassigned gowthamkpr May 11, 2020
@gowthamkpr gowthamkpr added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label May 11, 2020
@kumariko kumariko self-assigned this Aug 27, 2021
@kumariko
Copy link

@cowwoc Could you please let us know if this issue still persists ? If it it resolved then please feel free to move this issue to close status ?Thanks!

@kumariko kumariko added the stat:awaiting response Status - Awaiting response from author label Aug 27, 2021
@cowwoc
Copy link
Author
cowwoc commented Aug 27, 2021

@kumariko Yes, the issue still persists.

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Aug 29, 2021
@kumariko kumariko removed their assignment Sep 2, 2021
@gadagashwini
Copy link
Contributor
gadagashwini commented Feb 24, 2022

@gadagashwini gadagashwini added stat:awaiting response Status - Awaiting response from author and removed stat:awaiting tensorflower Status - Awaiting response from tensorflower labels Feb 24, 2022
@cowwoc
Copy link
Author
cowwoc commented Feb 24, 2022

@gadagashwini What are you asking? Did you add module-info.java to Tensorflow?

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Feb 26, 2022
@gadagashwini
Copy link
Contributor

@cowwoc, As you can see https://www.tensorflow.org/install/lang_java_legacy#tensorflow_with_the_jdk Tensorflow has Java compiler. Thanks!

@gadagashwini gadagashwini added the stat:awaiting response Status - Awaiting response from author label Mar 3, 2022
@cowwoc
Copy link
Author
cowwoc commented Mar 3, 2022

@gadagashwini Sure, but this issue is about "Java Module" support which is about a lot more than just providing Java support.

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Mar 6, 2022
@mohantym mohantym self-assigned this Nov 16, 2022
@mohantym
Copy link
Contributor

Hi @cowwoc !
I could locate module-info.java here in Tensorflow/Java repo.

Could you check the run time from Tensorflow/Java for your usecase.

Thank you!

@mohantym mohantym added the stat:awaiting response Status - Awaiting response from author label Nov 16, 2022
@cowwoc
Copy link
Author
cowwoc commented Nov 16, 2022

Sorry @mohantym I'm not working on any AI projects at the moment. Can anyone else test?

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Nov 16, 2022
@mohantym
Copy link
Contributor
mohantym commented Nov 17, 2022

@cowwoc !
I am saying Tensorflow/Java can run JVM (Java virtual Machine) based on this statement.
Recently got confirmation on Java runtime being actively maintained here Tensorflow/Java from here.

Other language binding and signature builds are being supported through Tensorflow/Build and Tensorflow/Community.
I can test in a Java Virtual Machine and update you sometime for sure.

Thank you!

@mohantym mohantym added the type:feature Feature requests label Nov 17, 2022
@cowwoc
Copy link
Author
cowwoc commented Nov 17, 2022

I don't think you understand what Java Module (JPMS) is. It's not enough to say that Tensorflow/Java can run under a JVM. You'll need to create a new application that uses JPMS and import TensorFlow in your module-info.java and check for errors at compile-time and runtime.

@mohantym
Copy link
Contributor

@cowwoc !

Thanks for the update. will let you know once i have some update on above pointers.

Thank you!

@mohantym mohantym removed their assignment Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build/install Build and install issues type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

8 participants