[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle called_computation in AbslHashValue #55604

Open
mavenlin opened this issue Apr 13, 2022 · 0 comments
Open

Handle called_computation in AbslHashValue #55604

mavenlin opened this issue Apr 13, 2022 · 0 comments
Assignees
Labels
comp:xla XLA stat:awaiting tensorflower Status - Awaiting response from tensorflower TF 2.8 type:feature Feature requests

Comments

@mavenlin
Copy link
Contributor

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template

System information

  • TensorFlow version (you are using): master
  • Are you willing to contribute it (Yes/No): yes

Describe the feature and the current behavior/state.

https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/service/hlo_instruction.h#L1315
Only kFusion is considered in this code, modify to the following code to consider other instructions that has a called_computation.

if (!hlo.called_computations().empty()) {
  for (auto* comp : hlo.called_computations()) {
    h = H::combine(std::move(h), *comp);
  }
}

if (hlo.opcode() == HloOpcode::kFusion) {
  h = H::combine(std::move(h), hlo.fusion_kind(), 
                 hlo.fused_instruction_count(),
                 hlo.fused_parameters().size());
}

Will this change the current api? How?
No

Who will benefit with this feature?
Everyone who is using the hash value to distinguish different computations.

Any Other info.

@mavenlin mavenlin added the type:feature Feature requests label Apr 13, 2022
@mohantym mohantym assigned gadagashwini and unassigned mohantym Apr 13, 2022
@sachinprasadhs sachinprasadhs added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:xla XLA stat:awaiting tensorflower Status - Awaiting response from tensorflower TF 2.8 type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

5 participants