[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update the links on documentation page, pointing to the new location - moved to /src #66572

Closed
EonosLovos opened this issue Apr 28, 2024 · 9 comments
Closed

Please update the links on documentation page, pointing to the new location - moved to /src #66572

EonosLovos opened this issue Apr 28, 2024 · 9 comments
Assignees
@MarkDaoust @tilakrayal
Labels
comp:keras Keras related issues stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author type:docs-bug Document issues

Comments

@EonosLovos
Copy link
EonosLovos commented Apr 28, 2024 •
edited
Loading

Hello!

Thank you for all the awesome things you have done!

I was browsing tf.keras documentation pages, for example

https://www.tensorflow.org/api_docs/python/tf/keras/layers/Dropout

and noticed that the pages do not find the lines in source code as expected, instead the 404 is being shown in the middle of github page where source code would be supposed to be.

in order for the links to work as expected, it seems that after branch number and keras another folder, /src should be added.

I mean:

https://github.com/keras-team/keras/tree/v3.3.3/keras/layers/regularization/dropout.py#L6-L76

becomes

https://github.com/keras-team/keras/blob/v3.3.3/keras/src/layers/regularization/dropout.py#L6-L76

h_ttps://github.com/keras-team/keras/blob/v3.3.3/keras/ src/ layers/regularization/dropout.py#L6-L76
@Venkat6871 Venkat6871 added comp:keras Keras related issues type:docs-bug Document issues labels Apr 30, 2024
@sachinprasadhs
Copy link
Contributor

@MarkDaoust , Could you please look into this. Thanks!

@sachinprasadhs sachinprasadhs added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label May 2, 2024
@MarkDaoust
Copy link
Member

Fix inflight.

@sachinprasadhs
Copy link
Contributor

@EonosLovos Here is the fix commit ca59b90
@MarkDaoust , When does the change reflect in the webpage?

@MarkDaoust
Copy link
Member

Probably Thursday.

@tilakrayal
Copy link
Contributor
tilakrayal commented Jun 13, 2024 •
edited
Loading

@EonosLovos,
Could you please try to access the respective Keras page in the Tensorflow.org page, now it is able to re-direct to correct source code instead of 404 error. Please check and confirm if it is working in your case.
https://www.tensorflow.org/api_docs/python/tf/keras/layers/Dropout
https://github.com/keras-team/keras/blob/v3.3.3/keras/src/layers/regularization/dropout.py#L6-L76

Thank you!

@tilakrayal tilakrayal added stat:awaiting response Status - Awaiting response from author and removed stat:awaiting tensorflower Status - Awaiting response from tensorflower labels Jun 13, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Jun 21, 2024
@github-actions GitHub Actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.

@google-ml-butler Google-ML-Butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@MarkDaoust
Copy link
Member

This is actually fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkDaoust MarkDaoust

@tilakrayal tilakrayal

Labels
comp:keras Keras related issues stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author type:docs-bug Document issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MarkDaoust @sachinprasadhs @tilakrayal @EonosLovos @Venkat6871