[XLA:FFI] Reduce the cost of FFI CallFrame creation and destruction. #70519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reduces the cost of custom calls that involve a large number of argument and return buffers. - Call `std::vector::reserve` before populating the arguments and returns list. - Eliminate the copying of dims vectors from `CallFrameBuilder::Buffer` into `CallFrame::Buffer`. Reverts 49f4d90 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13106 from buptzyb:asyncpool f25bd029f1308b23ab8f91876ae967fcfad29890 PiperOrigin-RevId: 647321728
7b77ed8
to
2a1d0b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:FFI] Reduce the cost of FFI CallFrame creation and destruction.
This change reduces the cost of custom calls that involve a large number of argument and return buffers.
Call
std::vector::reservebefore populating the arguments and returns list.Eliminate the copying of dims vectors from
CallFrameBuilder::BufferintoCallFrame::Buffer.Reverts 49f4d90
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13106 from buptzyb:asyncpool f25bd029f1308b23ab8f91876ae967fcfad29890