[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] Implement of batchToSpaceND #2994

Closed
akineeic opened this issue Mar 30, 2020 · 5 comments · Fixed by #5288
Closed

[WASM] Implement of batchToSpaceND #2994

akineeic opened this issue Mar 30, 2020 · 5 comments · Fixed by #5288
Assignees
@jinjingforever
Labels
comp:wasm stat:contributions welcome type:feature New feature or request

Comments

@akineeic
Copy link

Hello, I want to do inference with SRGAN (a super resolution model) but found there is no implement of batchToSpaceND in tfjs-backend-wasm. So I'd like to know do you have plan to implement this op in tfjs-backend-wasm since it's a commonly used op in super resolution model.

Looking forward to your reply.
@annxingyuan annxingyuan self-assigned this Mar 30, 2020
@annxingyuan
Copy link
Collaborator
annxingyuan commented Mar 30, 2020 •
edited
Loading

Hi @akineeic - yes this is on our medium-term roadmap - batchToSpaceND and spaceToBatchND are required for models in our repo as well (e.g. DeepLab).

@rthadur rthadur added comp:wasm type:feature New feature or request labels Mar 30, 2020
@akineeic
Copy link
Author

Thanks for your quickly reply. By the way, I'm wondering if your goal is to make wasm backend the same as webgl. For example the maximum in wasm doesn't support broadcasting along inner dims yet, will you still try to implement these missing features.

@akineeic akineeic mentioned this issue Mar 31, 2020
Merged
@annxingyuan
Copy link
Collaborator

Yes, we would like our backends to be interchangeable with each other as much as possible. We are gradually adding features to our WASM backend. We look to GitHub issues (like this one) for signal on which features should be prioritized :)

@akineeic
Copy link
Author

Thanks for your information, that is helpful for me.

@akineeic akineeic mentioned this issue Aug 18, 2020
Open
@F0REacH
Copy link
F0REacH commented Dec 11, 2020

spaceToBatchND is the only kernel stopping WASM use in production. Please add this feature.

@kon72 kon72 mentioned this issue Jul 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinjingforever jinjingforever

Labels
comp:wasm stat:contributions welcome type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wasm] Add batchToSpaceND/spaceToBatchND kernels kon72/tfjs
5 participants
@F0REacH @annxingyuan @jinjingforever @rthadur @akineeic