[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allocation in connection_params parsing #59

Open
tgockel opened this issue Nov 19, 2017 · 0 comments
Open

Remove allocation in connection_params parsing #59

tgockel opened this issue Nov 19, 2017 · 0 comments
Labels
enhancement lib/main priority/low
Projects
main

Comments

@tgockel
Copy link
Owner
tgockel commented Nov 19, 2017

extract_millis in connection.cpp uses std::stod, which requires conversion to a std::string -- an allocation. We should use std::from_chars but this is not supported (as of GCC 7.2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement lib/main priority/low
Projects
main
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tgockel