[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validations for included, excluded and priority nodes #1017

Open
rawdaGastan opened this issue May 19, 2024 · 4 comments
Open

Add validations for included, excluded and priority nodes #1017

rawdaGastan opened this issue May 19, 2024 · 4 comments
Assignees
@SalmaElsoly @Eslam-Nawara
Labels
farmerbot type_feature New feature or request
Milestone
v0.16.0

Comments

@rawdaGastan
Copy link
Collaborator

Is your feature request related to a problem? Please describe

To make sure config file is valid, so farmer could notice if the date is wrong or messy

Describe the solution you'd like

Add validations for included, excluded and priority nodes
@rawdaGastan rawdaGastan added type_feature New feature or request farmerbot labels May 19, 2024
@rawdaGastan rawdaGastan mentioned this issue May 19, 2024
Merged
@rawdaGastan rawdaGastan added this to the later milestone May 22, 2024
@A-Harby
Copy link
Contributor
A-Harby commented Jun 11, 2024

Qanet v0.15.10.

Input validation is working correctly.
image

Updated validation to all cases.
TC2718 - Farmer Bot Installation with priority_nodes
TC2472 - Farmer Bot Installation with excluded_nodes
TC2466 - Farmer Bot Installation with never_shutdown_nodes

@A-Harby
Copy link
Contributor
A-Harby commented Jun 11, 2024

But the node priority needs a validation on the node ID to check if it is on the same farm or not.

Farm 180 doesn't have node 291.

farm_id: 180
included_nodes:
  - 26
  - 28
  - 29
excluded_nodes:
  - 27
priority_nodes:
  - 291

The Famerbot is stuck on this error.
image

@rawdaGastan rawdaGastan modified the milestones: later, v0.16.0 Jul 4, 2024
@SalmaElsoly SalmaElsoly mentioned this issue Jul 29, 2024
Merged
4 tasks
@SalmaElsoly
Copy link
Contributor

added nodes validation:

  • included, excluded and priority nodes are in the farm
  • priority nodes are subset of included nodes
  • no overlapping nodes between included and excluded
  • no overlapping nodes between priority and excluded

@SalmaElsoly
Copy link
Contributor
  • added never shutdown validation
  • handled case of all nodes of the farm included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SalmaElsoly SalmaElsoly

@Eslam-Nawara Eslam-Nawara

Labels
farmerbot type_feature New feature or request
Projects
3.15.x
Status: In Verification
Milestone
v0.16.0
Development

No branches or pull requests
4 participants
@rawdaGastan @SalmaElsoly @Eslam-Nawara @A-Harby