[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suborigin names should not be allowed to start with number #47

Closed
joelweinberger opened this issue Sep 26, 2016 · 4 comments
Closed

Suborigin names should not be allowed to start with number #47

joelweinberger opened this issue Sep 26, 2016 · 4 comments
Assignees
@joelweinberger
Milestone
v1

Comments

@joelweinberger
Copy link
Contributor

At the very least, suborigin names should not be allowed to be a pure number, as in the serialization this could easily lead to parsing bugs that confuse the suborigin name with an IP literal. It's probably sufficient to just ban starting with a number, although perhaps we should outright disallow numerals.
@joelweinberger joelweinberger self-assigned this Sep 26, 2016
@annevk
Copy link
Member
annevk commented Sep 27, 2016

Maybe we should instead figure out what is absolutely safe in all the various contexts and use that? E.g., lowercase a-z?

@devd
Copy link
Contributor
devd commented Sep 27, 2016

I like the lowercase a-z idea. It also gives us ability to namespace later via upper case / numbers (for #40 )

@ghost
Copy link
ghost commented Sep 29, 2016

a-z would break our current usage of suborigin in IPFS, where we use multihashes as suborigin names to isolate e.g. /ipfs/Qmfoo from /ipfs/Qmbar. I suppose we could encode the hashes with a-z only, but that's less ideal than base32.

It's probably sufficient to just ban starting with a number, although perhaps we should outright disallow numerals.

Both of these would work for go-ipfs 👍

@ghost ghost mentioned this issue Sep 29, 2016
Closed
@joelweinberger joelweinberger added this to the v1 milestone Sep 30, 2016
@joelweinberger joelweinberger removed the v1 label Sep 30, 2016
@joelweinberger joelweinberger mentioned this issue Oct 26, 2016
Merged
@devd
Copy link
Contributor
devd commented May 13, 2017

closed per above merge

@devd devd closed this as completed May 13, 2017
@lidel lidel mentioned this issue Jan 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelweinberger joelweinberger

Labels
None yet
Projects
None yet
Milestone
v1
Development

No branches or pull requests
3 participants
@devd @joelweinberger @annevk