[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-typed-om] StylePropertyMapReadOnly.get return type should be nullable #1095

Open
j-f1 opened this issue May 8, 2023 · 0 comments
Open

[css-typed-om] StylePropertyMapReadOnly.get return type should be nullable #1095

j-f1 opened this issue May 8, 2023 · 0 comments

Comments

@j-f1
Copy link
j-f1 commented May 8, 2023

Spec section: https://drafts.css-houdini.org/css-typed-om/#the-stylepropertymap

Current implementation:

interface StylePropertyMapReadOnly {
  (undefined or CSSStyleValue) get(USVString property);
}

I think this should be:

interface StylePropertyMapReadOnly {
  CSSStyleValue? get(USVString property);
}

I don’t think there are any other specs that use the (undefined or X) union style to express an optional return value, but there are plenty of specs that use X?, e.g. DataTransferItem.getAsFile()
@j-f1 j-f1 changed the title [css-typed-om] StylePropertyMapReadOnly.get return value should be nullable [css-typed-om] StylePropertyMapReadOnly.get return type should be nullable May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@j-f1