[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering the logs by the selected node automatically #6787

Open
skyrpex opened this issue Jun 25, 2024 · 3 comments
Open

Allow filtering the logs by the selected node automatically #6787

skyrpex opened this issue Jun 25, 2024 · 3 comments
Labels
🛫 console Console ✨ enhancement New feature or request

Comments

@skyrpex
Copy link
Contributor
skyrpex commented Jun 25, 2024

The proposal consists of:

  • Add an additional option "Selected resource" checkbox to the Resources Filter, in the Logs (below the "All resources" option)
    • If enabled, the logs will be filtered by the currently selected resource
    • Choosing either "All resources" or any specific resource, will uncheck the "Selected resource" option

Related to #6593.

@skyrpex skyrpex added ✨ enhancement New feature or request 🛫 console Console labels Jun 25, 2024
@skyrpex skyrpex self-assigned this Jun 25, 2024
@skyrpex
Copy link
Contributor Author
skyrpex commented Jun 25, 2024

Maybe, instead of adding a checkbox, we could add an additional option inside the filter by resource dropdown:

image

We could have All resources | Current (or selected) resource | Remaining options....

@polamoros
Copy link
Collaborator

I think it makes sense to add it to the existing resource dropdown 👍

@skyrpex
Copy link
Contributor Author
skyrpex commented Jun 27, 2024

I wonder if filtering given a specific resource is too limiting. For example, imagine this map:

root
  | container
  | | service
  | | | function

Selecting container or service would make the logs empty. I'm thinking that we could show the logs of child resources as well?

@skyrpex skyrpex added needs-discussion Further discussion is needed prior to impl and removed needs-discussion Further discussion is needed prior to impl labels Jun 27, 2024
@skyrpex skyrpex removed their assignment Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛫 console Console ✨ enhancement New feature or request
Projects
Status: 🆕 New - not properly defined
Development

No branches or pull requests

2 participants