[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Comment view changes form when changing orientation. #496

Closed
aerych opened this issue Dec 16, 2013 · 6 comments
Closed

Editor: Comment view changes form when changing orientation. #496

aerych opened this issue Dec 16, 2013 · 6 comments

Comments

@aerych
Copy link
Member
aerych commented Dec 16, 2013

Start in landscape orientation.
From a post detail, tap the comment icon to view the Write Comment dialog.
Rotate to portrait orientation.
Rotate back to landscape.
The form is replaced by a full screen text field.

Nexus 4 / KitKat

@roundhill
Copy link
Contributor

This is intended Android behavior, if I've read this correctly. When a focused EditText is rotated from portrait to landscape (on a phone), it will show the full screen editor.

@aerych
Copy link
Member Author
aerych commented Dec 17, 2013

Sure, but shouldn't it start out as a full screen editor then? It starts out in landscape orientation as the same form presented in portrait orientation.

@roundhill
Copy link
Contributor

I don't think so, as the user needs to know that they are looking at an Alert Dialog first.

@aerych
Copy link
Member Author
aerych commented Dec 17, 2013

Well, its probably an edge case with the multiple rotations. I thought it was weird but maybe it won't be something that turns up often.

@roundhill
Copy link
Contributor

We'll let this one simmer, for now I've removed the 2.6 milestone.

@maxme maxme added the comments label Jun 17, 2014
@maxme
Copy link
Contributor
maxme commented Jun 17, 2014

if I've read this correctly. When a focused EditText is rotated from portrait to landscape (on a phone), it will show the full screen editor

Yep, that's why it doesn't start out as a full screen editor (it's not focused).

I'm closing this, feel free to reopen if you see weird behavior.

@maxme maxme closed this as completed Jun 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants