[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media Library - The "state" of items seems to be inconsistent #5483

Closed
daniloercoli opened this issue Mar 23, 2017 · 7 comments
Closed

Media Library - The "state" of items seems to be inconsistent #5483

daniloercoli opened this issue Mar 23, 2017 · 7 comments
Assignees
@mzorz
Labels
Media [Type] Bug
Projects
Media

Comments

@daniloercoli
Copy link
Contributor
daniloercoli commented Mar 23, 2017 •
edited
Loading

I was testing uploading in the Media Library and found out a couple of issues that I think are all related each other. So i'm opening this single issue, but feel free to decouple, if they're different issues.

Issue 1 (Video here: https://cloudup.com/cbfyyY7d-4l )

  • Not sure how, but I found myself with 2 items in the "Uploading" state in the library. Only one should be in the uploading state, and the other one should be in the "Queued" state.
  • Adding a new item to the queue switches the status of the 3 new items to "Queued" and the spinning is running on the top of the text.

Issue 2 (Video here: https://cloudup.com/cCKVhkgeRl7 )

  • Starting from an incoherent state where all the 3 items are in the "Queued" state.
  • PTR and the state issue seems to be fixed. Again, not sure why there is the spinner running in the Queued state though.
  • Single click on the queue files does nothing, or it's hard to tap on the correct area to open the details screen.
  • Long clicked, selected an item in the Queued state, and selected Delete. All the 3 items disappeared from the screen. When I did PTR the one in the uploading state reappeared on the library.

Issue 3 (Video here: https://cloudup.com/chaZh-1rFwl )

  • Long click are enabled on the items in "Uploading" state. It should not be enabled I think.
    Only the single tap to stop the uploading should be available. (Open to suggestions on this).

cc @nbradbury
@nbradbury nbradbury self-assigned this Mar 23, 2017
@nbradbury nbradbury mentioned this issue Mar 23, 2017
Merged
@nbradbury nbradbury removed their assignment Mar 23, 2017
@nbradbury
Copy link
Contributor

Again, not sure why there is the spinner running in the Queued state though.

Resolved in #5488

@nbradbury
Copy link
Contributor

Long click are enabled on the items in "Uploading" state. It should not be enabled I think.
Only the single tap to stop the uploading should be available.

Based on a Slack discussion about this, we're going to enable long-pressing any non-deleted item. If an uploading item is selected and deleted, we're going to cancel the upload. @mzorz is currently working on adding the ability to cancel an upload when multiple uploads are underway.

@daniloercoli daniloercoli added this to WordPress Media Library in Media Mar 28, 2017
@daniloercoli
Copy link
Contributor Author
daniloercoli commented Mar 28, 2017 •
edited
Loading

Steps to replicate no. 1 (I think all of them are related, so fixing one will fix almost all of them) :

  • Go to Media Library.
  • Tap the '+' button to add a new media, select capture photo.
  • Take a new photo and approve it.
  • The app shows the item with the correct Uploading state and the loading spinner.
  • Tap the '+' button to add a new media, select capture photo.
  • Take a new photo and approve it.
  • The app shows the 2 new items in the Queued state.

Optional:

  • Don't touch the device or do anything. Wait until the uploading of the first item finishes.
  • The app refreshes the screen and the 2nd item is correctly shown as "Uploading.

@mzorz
Copy link
Contributor
mzorz commented Apr 4, 2017

Just FYI - I will test and tackle this as part of the multiupload/multicancel WIP tests, when integration is done 👍

@mzorz
Copy link
Contributor
mzorz commented Jun 26, 2017

Feedback collected from @nbradbury for later reference: * I attached two videos to a post, then viewed the media browser and saw a RETRY item and a QUEUED item. Not sure if this is in any way related to async changes, but I found it odd that it didn't automatically retry, and that the QUEUED item was apparently stuck until I retried the other item.

@mzorz
Copy link
Contributor
mzorz commented Aug 15, 2017 •
edited
Loading

I think this should be ready since #6515 has been fixed. @daniloercoli would you like to test it again and confirm whether we still have any erratic behavior?

@daniloercoli
Copy link
Contributor Author

I'm going to close this post since the original issue seems fixed, even though I found other glitches with Media in Aztec + Media Library. Will open new tickets for those.

@mzorz mzorz moved this from WordPress Media Library to Done in Media Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzorz mzorz

Labels
Media [Type] Bug
Projects
No open projects
Media
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniloercoli @nbradbury @mzorz