[go: nahoru, domu]

Page MenuHomePhabricator

WikiLove's internal API request should use the 'tags' parameter instead of manually adding the change tag
Open, MediumPublic

Description

The WikiLove extension makes an internal API request (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLove/+/refs/heads/master/includes/ApiWikiLove.php#73) and then later manually calls ChangeTags::addTags to add the "wikilove" tag. Instead it should use the tags= parameter for the API (as the code already supports) to add the change tag.

Event Timeline

Legoktm raised the priority of this task from to Medium.
Legoktm updated the task description. (Show Details)
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

(A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. Given the current short task description I'm removing the good first task tag. Please add details what exactly has to happen where and how for a new contributor, and then add back the good first task project tag. Thanks a lot in advance!)

Change #1033593 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/WikiLove@master] Add 'wikilove' tag through the API instead of a DefferedUpdate

https://gerrit.wikimedia.org/r/1033593