[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T164228

Do not rebind and blindly override onMenuToggle in FilterTagMultiselectWidget
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

onMenuToggle exists in the parent class, but it's blindly overridden with duplication of some (but not all!) of the parent's logic, and it's bound again in the constructor. This means that it runs twice, and that the code for counting how many times the highlight button has been shown double-counts every instance of the menu opening.

Details

SubjectRepoBranchLines +/-
RC Filters: don't bind onMenuToggle twicemediawiki/coremaster+5 -4
Customize query in gerrit

Event Timeline

Catrope created this task.May 1 2017, 10:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2017, 10:24 PM
Catrope set the point value for this task to 1.May 1 2017, 10:34 PM
Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
SBisson claimed this task.May 2 2017, 2:35 PM
SBisson moved this task from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
gerritbot subscribed.May 2 2017, 2:52 PM

Change 351322 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] RC Filters: don't bind onMenuToggle twice

https://gerrit.wikimedia.org/r/351322

gerritbot added a project: Patch-For-Review.May 2 2017, 2:52 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 2 2017, 2:52 PM
gerritbot added a comment.May 2 2017, 4:28 PM

Change 351322 merged by jenkins-bot:
[mediawiki/core@master] RC Filters: don't bind onMenuToggle twice

https://gerrit.wikimedia.org/r/351322

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 2 2017, 4:47 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 2 2017, 5:00 PM
Etonkovidova subscribed.EditedMay 15 2017, 9:16 PM

Re-checked in betalabs - rcenhancedfilters-seen-highlight-button-counter value increases correctly according to users' input.

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 15 2017, 9:17 PM
• jmatazzoni closed this task as Resolved.May 27 2017, 12:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits