Maniphest T193324

Blocks don't retain the custom duration
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Apr 28 2018, 2:54 PM

Tags

Referenced Files

None

Subscribers

Tokens

"Baby Tequila" token, awarded by RandomDSdevel.

Description

I noticed by chance that, since 1.32-wmf.1, custom block durations aren't applied. In fact, on itwiki, blocks started to have the global default duration since April 26th. Given the fact that we don't have a clean changelog on mediawiki, it'll take me some time to identify the culprit patch, but I strongly suspect of this one (more or less the only relevant one). I'll start investigating right now, in case someone wants to join feel free to.

Related Objects

Mentioned In: T193339: Notice: Undefined index: 0 in /srv/mediawiki/php-1.32.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilter.php on line 1498

Event Timeline

Daimona created this task.Apr 28 2018, 2:54 PM

Restricted Application added subscribers: • OldUser02, Aklapper. · View Herald TranscriptApr 28 2018, 2:54 PM

Triaging as high because we still have a default duration, would've been UBN otherwise.

Oh, well. Yeah, that's the culprit, but the bug has already been solved on master with this patch. If a sysadmin is around and could merge the cherry pick on 1.32-wmf.1, feel free to. Otherwise I'll set it for monday's SWAT.

Cherry picked as https://gerrit.wikimedia.org/r/#/c/429570/

Daimona mentioned this in T193339: Notice: Undefined index: 0 in /srv/mediawiki/php-1.32.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilter.php on line 1498.Apr 29 2018, 4:39 PM

Merged with SWAT right now. However, as far as I could see, custom durations need to be reset manually for each filter.

Daimona moved this task from To Triage to Announce in next Tech/News on the User-notice board.Apr 30 2018, 1:48 PM

Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.May 3 2018, 2:42 PM

RandomDSdevel awarded a token.May 9 2018, 1:33 AM

Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.May 10 2018, 10:30 PM

• Vvjjkkii renamed this task from Blocks don't retain the custom duration to 70daaaaaaa.Jul 1 2018, 1:13 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Daimona as the assignee of this task.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed AbuseFilter.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

Mainframe98 renamed this task from 70daaaaaaa to Blocks don't retain the custom duration.Jul 1 2018, 9:16 AM

Mainframe98 closed this task as Resolved.

Mainframe98 assigned this task to Daimona.

Mainframe98 edited projects, added AbuseFilter; removed TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Mainframe98 updated the task description. (Show Details)

Mainframe98 added a subscriber: Aklapper.

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM