[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T228855

Fix broken WikibaseQualityConstraints tests
Closed, ResolvedPublic
Actions

Description

Some tests for WikibaseQualityConstraints fail on quibble-vendor-mysql-hhvm-docker with the error message:

PHPUnit_Framework_MockObject_RuntimeException: The provided class "Mock_WANObjectCache_157858e2" does not exist

This is blocking merges.

Example failure: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/525234

Details

SubjectRepoBranchLines +/-
Do not mock WANObjectCache and BagOfStuff in testsmediawiki/extensions/WikibaseQualityConstraintsmaster+76 -55
DNM yet - jut triggering quibble to test CI failures for nowmediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Michael created this task.Jul 24 2019, 11:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2019, 11:43 AM
• Michael triaged this task as High priority.Jul 24 2019, 11:44 AM
• Michael raised the priority of this task from High to Needs Triage.
• Michael triaged this task as High priority.
• Michael updated the task description. (Show Details)
• alaa_wmde raised the priority of this task from High to Unbreak Now!.Jul 24 2019, 12:30 PM
• alaa_wmde subscribed.

As it blocks others' work from being delivered

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJul 24 2019, 12:30 PM
• alaa_wmde claimed this task.Jul 24 2019, 12:30 PM
• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
• alaa_wmde added a comment.Jul 24 2019, 2:44 PM

quick update: so far quibble isn't failing for me locally

gerritbot added a comment.Jul 24 2019, 2:51 PM

Change 525299 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] DNM yet - jut triggering quibble to test CI failures for now

https://gerrit.wikimedia.org/r/525299

gerritbot added a project: Patch-For-Review.Jul 24 2019, 2:51 PM
gerritbot added a comment.Jul 24 2019, 3:14 PM

Change 525304 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/WikibaseQualityConstraints@master] [DNM] - just testing quibble build

https://gerrit.wikimedia.org/r/525304

• Michael added a comment.Jul 24 2019, 4:19 PM

This comment seems to be related: https://phabricator.wikimedia.org/T192166#4475526

• alaa_wmde moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 24 2019, 6:23 PM
In T228855#5361929, @Michael wrote:

This comment seems to be related: https://phabricator.wikimedia.org/T192166#4475526

yeap it is same problem in here .. we need to speed up upgrading phpunit 😁

• alaa_wmde moved this task from incoming to in progress on the Wikidata board.Jul 24 2019, 8:32 PM
gerritbot added a comment.Jul 24 2019, 10:41 PM

Change 525304 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Do not mock WANObjectCache and BagOfStuff in tests

https://gerrit.wikimedia.org/r/525304

• alaa_wmde mentioned this in rEBQC8c5117f1290c: Do not mock WANObjectCache and BagOfStuff in tests.Jul 24 2019, 10:45 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 24 2019, 11:00 PM
• alaa_wmde added a comment.Jul 24 2019, 11:42 PM
This comment was removed by • alaa_wmde.
gerritbot added a comment.Jul 24 2019, 11:42 PM

Change 525299 abandoned by Alaa Sarhan:
DNM yet - jut triggering quibble to test CI failures for now

https://gerrit.wikimedia.org/r/525299

• alaa_wmde moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 24 2019, 11:52 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 25 2019, 12:10 AM
• Michael lowered the priority of this task from Unbreak Now! to High.Jul 25 2019, 9:50 AM

The lines that were changed have been created about a year ago. Do we have an idea what changed to cause them to break now?

Also, lowering priority as this seems to not break builds anymore.

• alaa_wmde added a comment.Jul 26 2019, 12:58 PM
In T228855#5364427, @Michael wrote:

The lines that were changed have been created about a year ago. Do we have an idea what changed to cause them to break now?

Also, lowering priority as this seems to not break builds anymore.

This happened https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524646 then PHPUnit started complaining

Lucas_Werkmeister_WMDE closed this task as Resolved.Sep 16 2019, 6:16 PM
Lucas_Werkmeister_WMDE subscribed.

Whatever this was, it seems to be fixed by now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits