Maniphest T271203

Stop accessing global $wgTitle from SecurePoll maintenance scripts
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Tchanders
	Jan 5 2021, 1:49 PM

Tags

Referenced Files

None

Subscribers

Description

We should stop accessing the global $wgTitle from:

dumpComments.php
tally.php
dumpVoteCsv.php

The variable appears to be unused in these classes.

Details

	Subject	Repo	Branch	Lines +/-
	Remove unused $wgTitle global	mediawiki/extensions/SecurePoll	master	+0 -15

Customize query in gerrit

Event Timeline

• Tchanders created this task.Jan 5 2021, 1:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2021, 1:49 PM

• Tchanders moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 5 2021, 4:59 PM

• Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

STran claimed this task.Jan 5 2021, 7:29 PM

Change 654488 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Remove unused $wgTitle global

https://gerrit.wikimedia.org/r/654488

gerritbot added a project: Patch-For-Review.Jan 5 2021, 8:29 PM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 5 2021, 8:51 PM

• Tchanders moved this task from Code Review 🔍 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.Jan 6 2021, 5:03 PM

Change 654488 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Remove unused $wgTitle global

https://gerrit.wikimedia.org/r/654488

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 6 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 6 2021, 6:10 PM

Niharika moved this task from Done: Q2 (2020-2021) ✅ to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Jan 6 2021, 7:27 PM

Niharika closed this task as Resolved.Jan 25 2021, 10:44 PM