[go: nahoru, domu]

Page MenuHomePhabricator

Deprecate and remove $wgAPIRequestLog
Open, In Progress, MediumPublic

Description

$wgAPIRequestLog predates standardized structured logging in MediaWiki, and is basically superseded by ApiMain::logRequest() which provides the api (space-separated) and api-request (structured context) channels.

Event Timeline

Krinkle added a project: MW-Interfaces-Team.
Krinkle subscribed.

Suggesting this as idea to consider for MWI team.

So this is asking to remove the code in ApiEntryPoint that ends up calling this:

             LegacyLogger::emit(
				implode(
					',',
					$items
				) . "\n",
				$apiRequestLog
			);

We have a mechanism now that will warn people when running the updater if they have outdated config variables. We can use that.

aaron changed the task status from Open to In Progress.Mon, Jun 24, 3:46 PM
aaron moved this task from Backlog (Triaged and Ready) to In Progress on the MW-Interfaces-Team board.

Change #1049234 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] api: deprecate and deactivate $wgAPIRequestLog

https://gerrit.wikimedia.org/r/1049234