Exception: Serialization of 'Closure' is not allowed
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.37.0-wmf.12
reqId: 30fa455d-4204-40c8-9d78-0404273c0e2c
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   Exception: Serialization of 'Closure' is not allowed

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.12/includes/libs/objectcache/MemcachedPeclBagOStuff.php(423)
#0 /srv/mediawiki/php-1.37.0-wmf.12/includes/libs/objectcache/MemcachedPeclBagOStuff.php(423): serialize(stdClass)
#1 /srv/mediawiki/php-1.37.0-wmf.12/includes/libs/objectcache/MediumSpecificBagOStuff.php(974): MemcachedPeclBagOStuff->serialize(stdClass)
#2 /srv/mediawiki/php-1.37.0-wmf.12/includes/libs/objectcache/MediumSpecificBagOStuff.php(790): MediumSpecificBagOStuff->getSerialized(stdClass, string)
#3 /srv/mediawiki/php-1.37.0-wmf.12/includes/libs/objectcache/MediumSpecificBagOStuff.php(173): MediumSpecificBagOStuff->makeValueOrSegmentList(string, stdClass, integer, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.12/includes/Storage/PageEditStash.php(489): MediumSpecificBagOStuff->set(string, stdClass, integer, integer)
#5 /srv/mediawiki/php-1.37.0-wmf.12/includes/Storage/PageEditStash.php(172): MediaWiki\Storage\PageEditStash->storeStashValue(string, JsonSchemaContent, ParserOutput, string, User)
#6 /srv/mediawiki/php-1.37.0-wmf.12/includes/api/ApiStashEdit.php(198): MediaWiki\Storage\PageEditStash->parseAndCache(WikiPage, JsonSchemaContent, User, string)
#7 /srv/mediawiki/php-1.37.0-wmf.12/includes/api/ApiMain.php(1747): ApiStashEdit->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.12/includes/api/ApiMain.php(726): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.37.0-wmf.12/includes/api/ApiMain.php(697): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.37.0-wmf.12/api.php(90): ApiMain->execute()
#11 /srv/mediawiki/php-1.37.0-wmf.12/api.php(45): wfApiMain()
#12 /srv/mediawiki/w/api.php(3): require(string)
#13 {main}

Impact

Notes

Details

Request URL: https://meta.wikimedia.org/w/api.php

	Subject	Repo	Branch	Lines +/-
	JsonSchemaContent: Remove $revisionLookup and $linkRenderer props	mediawiki/extensions/EventLogging	master	+5 -14

Customize query in gerrit

Related Objects

Mentioned In: T368543: Error: Call to a member function getPageAsLinkTarget() on null
Mentioned Here: rEEVL3c4021e9be27: Replace deprecated usage of Linker::link

Event Timeline

dancy created this task.Jul 13 2021, 8:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2021, 8:37 PM

Assuming this is about MediaWiki-libs-BagOStuff

It only happens currently on metawiki during edits for the Schema namespace with a JsonSchemaContent object. So my guess is something regressed in JsonSchemaContent that it is now adding closures to the ParserOutput object, which is invalid.

Retagging EventLogging as the issue is not in the BagOStuff library.

Restricted Application added a project: Analytics. · View Herald TranscriptJul 14 2021, 6:48 PM

Krinkle moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.Jul 14 2021, 6:48 PM

In T286610#7213244, @Krinkle wrote:

Retagging EventLogging as the issue is not in the BagOStuff library.

PageEditStash creates a stdClass instance that contains the (JsonSchema)Content object and the ParserOutput (coming from (JsonSchema)ContentHandler. One of these apparently contains a Closure for some reason.

Platform Team Workboards (MW Expedition) got tagged since PET has touched PageEditStash recently. But I don't see anything offhand that could have caused this issue.

Ping @Milimetric

I have only cursory knowledge of JsonSchemaContentHandler, but I can take a look if nobody else can. We should probably make that call explicitly and at the same time determine exactly who's supposed to be maintaining this. The maintainers page just lists Yuri, who's been gone for... a while: https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_extensions_deployed_at_Wikimedia_Foundation

odimitrijevic removed a project: MediaWiki-extensions-EventLogging.Nov 29 2021, 11:00 PM

Re-tagging EventLogging. The JsonSchemaContentHandler class is part of that extension.

Restricted Application added a project: Data-Engineering. · View Herald TranscriptMar 15 2022, 12:25 AM

• EChetty moved this task from Incoming (new tickets) to Apache Iceberg Migration on the Data-Engineering board.Mar 24 2022, 3:17 PM

JArguello-WMF moved this task from Apache Iceberg Migration to Radar (External Teams) on the Data-Engineering board.Jun 29 2023, 11:35 PM

JArguello-WMF moved this task from Radar (External Teams) to Event Platform Backlog on the Data-Engineering board.

Krinkle removed a project: Platform Team Workboards (MW Expedition).Aug 18 2023, 7:37 PM

AFAICT this regression was introduced in rEEVL3c4021e9be27: Replace deprecated usage of Linker::link.

In T286610#7213309, @daniel wrote:

PageEditStash creates a stdClass instance that contains the (JsonSchema)Content object and the ParserOutput (coming from (JsonSchema)ContentHandler. One of these apparently contains a Closure for some reason.

The patch added the JsonSchemaContent::$linkRenderer property, which is initialised to the LinkRenderer instance returned by MediaWikiServices::getLinkRenderer(). The LinkRenderer::$titleFormatter property is initialised to the TitleFormatter instance returned by MediaWikiServices::getTitleFormatter(), an instance of MediaWikiTitleCodec. Finally, the MediaWikiTitleCodec::$createMalformedTitleException property is initialised to a static closure.

dancy unsubscribed.Aug 29 2023, 2:53 PM

Change 954251 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] JsonSchemaContent: Remove $revisionLookup and $linkRenderer props

https://gerrit.wikimedia.org/r/954251

gerritbot added a project: Patch-For-Review.Sep 1 2023, 10:09 AM

Change 954251 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] JsonSchemaContent: Remove $revisionLookup and $linkRenderer props

https://gerrit.wikimedia.org/r/954251

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 1 2023, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 1 2023, 11:10 PM

Being bold.

It would be nice to resolve the underlying design flaw that caused this issue. I added a comment to the patch with some thoughts.

dcausse mentioned this in T368543: Error: Call to a member function getPageAsLinkTarget() on null.Jul 4 2024, 8:25 AM

Exception: Serialization of 'Closure' is not allowedClosed, ResolvedPublicPRODUCTION ERRORActions