[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T300350

Await for Assert is missing
Closed, DuplicatePublic
Actions

Description

Await for Assert is missing and as per node documentation, it returns a truthy value. The truthy value is based as pending and an "actual" value can be obtained while putting an await.

For reference, check node documentation

RepositoryTask
mediawiki/core
mediawiki/extensions/Echo757874
mediawiki/extensions/ElectronPdfService757873

Details

SubjectRepoBranchLines +/-
selenium: Add await for Assertmediawiki/extensions/Echomaster+7 -7
Customize query in gerrit

Event Timeline

Osamaahmed17 created this task.Jan 28 2022, 10:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2022, 10:14 AM
Osamaahmed17 updated the task description. (Show Details)Jan 28 2022, 10:15 AM
Osamaahmed17 updated the task description. (Show Details)
gerritbot added a comment.Jan 28 2022, 10:21 AM

Change 757873 had a related patch set uploaded (by Osamaahmed17; author: Osamaahmed17):

[mediawiki/extensions/ElectronPdfService@master] selenium: Add await for Assert

https://gerrit.wikimedia.org/r/757873

gerritbot added a project: Patch-For-Review.Jan 28 2022, 10:21 AM
gerritbot added a comment.Jan 28 2022, 10:23 AM

Change 757874 had a related patch set uploaded (by Osamaahmed17; author: Osamaahmed17):

[mediawiki/extensions/Echo@master] selenium: Add await for Assert

https://gerrit.wikimedia.org/r/757874

gerritbot added a comment.Jan 28 2022, 10:28 AM

Change 757876 had a related patch set uploaded (by Osamaahmed17; author: Osamaahmed17):

[mediawiki/extensions/Echo@master] selenium: Add await for Assert

https://gerrit.wikimedia.org/r/757876

gerritbot added a comment.Jan 28 2022, 10:31 AM

Change 757876 abandoned by Osamaahmed17:

[mediawiki/extensions/Echo@master] selenium: Add await for Assert

Reason:

Duplicate commit

https://gerrit.wikimedia.org/r/757876

Osamaahmed17 updated the task description. (Show Details)Jan 28 2022, 10:42 AM
Osamaahmed17 updated the task description. (Show Details)
Osamaahmed17 updated the task description. (Show Details)Jan 28 2022, 10:44 AM
Osamaahmed17 updated the task description. (Show Details)
Osamaahmed17 updated the task description. (Show Details)
Aklapper added projects: Notifications, Electron-PDFs.Jan 28 2022, 11:56 AM
Aklapper updated the task description. (Show Details)
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 28 2022, 11:56 AM
Osamaahmed17 updated the task description. (Show Details)Jan 28 2022, 2:29 PM
zeljkofilipin triaged this task as Medium priority.Jan 28 2022, 4:03 PM
zeljkofilipin added a project: User-zeljkofilipin.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
Osamaahmed17 closed this task as a duplicate of T256626: Refactor WebdriverIO tests from sync to async mode.Jan 28 2022, 4:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits