[go: nahoru, domu]

Page MenuHomePhabricator

Local "Signwriting.js" gadget breaks rendering of sign language Incubator wikis with Vector 2022 skin
Open, Needs TriagePublicBUG REPORT

Assigned To
None
Authored By
Nikki
Jul 12 2022, 11:49 AM
Referenced Files
F35315187: asl3.png
Jul 12 2022, 11:49 AM
F35315185: asl2.png
Jul 12 2022, 11:49 AM
F35315186: asl1.png
Jul 12 2022, 11:49 AM
F35315180: libras3.png
Jul 12 2022, 11:49 AM
F35315181: libras2.png
Jul 12 2022, 11:49 AM
F35315179: libras1.png
Jul 12 2022, 11:49 AM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The page is a mess. It scrolls vertically as well as horizontally. The page text is squashed into a narrow row. The page tabs are scattered across the page and not all of them can be clicked. The ellipsis in the side menu is on top of the create account link. The top menu takes up most of the page. The footer overlaps the page content. There is a large amount of empty space at the bottom of the page. The text to open the interwiki links dialog overflows the button. The dialog it opens is far too large for the content.

What should have happened instead?:
The page should not have those issues. It should display as a more or less rotated version of the standard interface, like they do in the Vector skin (same ASL page, same Libras page).

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Libras page in Vector 2022:

libras1.png (1×1 px, 174 KB)
libras2.png (1×1 px, 282 KB)

Libras page in Vector for comparison:

libras3.png (1×1 px, 307 KB)

ASL page in Vector 2022:

asl1.png (1×1 px, 177 KB)

ASL page in Vector for comparison:

asl2.png (1×1 px, 270 KB)
asl3.png (1×1 px, 214 KB)

Event Timeline

Nikki renamed this task from Sign language Incubator projects are broken in the Vector 2022 skin to Sign language Incubator wikis are broken in the Vector 2022 skin.Jul 12 2022, 12:02 PM
Nikki updated the task description. (Show Details)
Jdlrobson subscribed.

I'm not too familiar with this project, but this appears to relate to a gadget or site style - when I add safe mode there are no problems here:
https://incubator.wikimedia.org/wiki/Wp/ase/AS10002S1f548M519x514S1f548481x490S10002489x487_AS1f550S15a37S20e00S26502M531x512S15a37501x488S1f550507x495S20e00487x499S26502469x498?useskin=vector-2022&safemode=1

Who is maintaining the site/gadget styles for this site so we can get best advise them on what to do?

Aklapper renamed this task from Sign language Incubator wikis are broken in the Vector 2022 skin to Local "Signwriting.js" gadget breaks rendering of sign language Incubator wikis with Vector 2022 skin.Jul 14 2022, 3:29 PM

On https://incubator.wikimedia.org/wiki/Special:Preferences#mw-prefsection-gadgets , Supports display of sign writing characters in Wp/ase is by default enabled. Per https://incubator.wikimedia.org/wiki/MediaWiki:Gadgets-definition that is located at signwriting [default|targets=desktop|mobile|top|ResourceLoader|dependencies=mediawiki.util]|Signwriting.js.
So its code is located at https://incubator.wikimedia.org/wiki/MediaWiki:Gadget-Signwriting.js
Disabling that gadget fixes the problem for me.

So the gadget code needs reworking at https://incubator.wikimedia.org/wiki/MediaWiki:Gadget-Signwriting.js

I'm not too familiar with this project, but this appears to relate to a gadget or site style - when I add safe mode there are no problems here:
https://incubator.wikimedia.org/wiki/Wp/ase/AS10002S1f548M519x514S1f548481x490S10002489x487_AS1f550S15a37S20e00S26502M531x512S15a37501x488S1f550507x495S20e00487x499S26502469x498?useskin=vector-2022&safemode=1

Disabling that gadget fixes the problem for me.

It doesn't fix the problem at all - it breaks it completely by making the text complete undecipherable. The gadget is what turns it into readable text.

I have added some Javascript in Common.js that will reload the page with ?useskin=vector applied if you visit a sign language test wiki while using Vector-2022. This should not be seen as a permanent solution, but as a temporary fix until MediaWiki:Gadget-Signwriting.js can be fixed to accomodate Vector-2022 (that is beyond my skill level unfortunately).

I have added some Javascript in Common.js that will reload the page with ?useskin=vector applied if you visit a sign language test wiki while using Vector-2022. This should not be seen as a permanent solution, but as a temporary fix until MediaWiki:Gadget-Signwriting.js can be fixed to accomodate Vector-2022 (that is beyond my skill level unfortunately).

Seems like a much better short term solution. Thanks for that @jhobsy.

I asked on the other ticket but who maintains this gadget? Am happy to help get it up and running again.

I asked on the other ticket but who maintains this gadget? Am happy to help get it up and running again.

That would be @Slevinski who is already subscribed to this ticket.

I found asl site is also misalignments under the timeless skin (my default skin).

Maybe should jump to vector in all skin for now, @jhsoby

But I think this shouldn't be a long-term solution.
I also use 2017 wikitext editor and this is not work well, too.
Maybe better the language for this type of vertical text should automatically set to a skin variant, the same way it is rendered when the language is set to an RTL language, such as Arabic, just I think.

@LaMagiaaa Thanks for the heads-up! You're right, the sign language test wikis look pretty terrible with the gadget enabled in all skins except legacy Vector, so I've amended the hack to use Vector no matter which skin is used.

Better support for vertical text is what the Vertical-Writing tag is about, but it's… not trivial.