[go: nahoru, domu]
Page MenuHomePhabricator
Create Task
Maniphest T313835

Add icon-only support to ToggleButton
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Regular Buttons detect when their only content is an icon, and make themselves square (32x32). ToggleButtons should also do this. Right now they don't, and icon-only ToggleButtons are wider than they are long (46x32). See https://doc.wikimedia.org/codex/latest/components/demos/toggle-button.html#stateful-icon-only

Screenshot from 2022-07-26 10-54-23.png (53×67 px, 553 B)
Screenshot from 2022-07-26 10-54-10.png (56×72 px, 599 B)
Regular buttonToggleButton

Details

SubjectRepoBranchLines +/-
Update Codex from v0.17.0 to v0.18.0mediawiki/coremaster+2 K -2 K
ToggleButton: Add icon-only detectiondesign/codexmain+62 -16
useIconOnlyButton: Factor out warn-once logic into new useWarnOnce composabledesign/codexmain+39 -20
Button: Move icon-only check into its own composabledesign/codexmain+142 -88
Button, Tabs: Factor out common slot content analysis codedesign/codexmain+341 -82
Customize query in gerrit

Related Objects

Event Timeline

• Catrope created this task.Jul 26 2022, 6:20 PM
• Catrope mentioned this in T326900: Vertical centering issues of text/multiline text and icons in several components .Jan 17 2023, 8:40 PM
ldelench_wmf triaged this task as Lowest priority.Jan 20 2023, 7:05 PM
ldelench_wmf moved this task from Inbox to Backlog on the Design-System-Team board.Jan 20 2023, 7:09 PM
egardner moved this task from Inbox to Proposed Component Updates on the Codex board.Feb 22 2023, 12:28 AM
Volker_E removed a parent task: T301996: Add full support for icon-only buttons.May 25 2023, 7:02 AM
Volker_E mentioned this in T301996: Add full support for icon-only buttons.May 25 2023, 7:05 AM
CCiufo-WMF added a project: Codex 1.0.Jun 20 2023, 7:15 PM
CCiufo-WMF moved this task from Backlog to Accessibility on the Codex 1.0 board.
CCiufo-WMF moved this task from Backlog to Needs Refinement on the Design-System-Team board.Jun 22 2023, 2:36 PM
CCiufo-WMF raised the priority of this task from Lowest to Medium.Jul 5 2023, 4:37 PM
CCiufo-WMF updated the task description. (Show Details)
CCiufo-WMF set the point value for this task to 2.
• Catrope added a comment.Jul 5 2023, 4:37 PM

As part of this we should also land https://gerrit.wikimedia.org/r/c/design/codex/+/817814 , so that we can more easily share the icon-only detection code between Button and ToggleButton.

CCiufo-WMF moved this task from Needs Refinement to Up Next on the Design-System-Team board.Jul 5 2023, 4:37 PM
egardner moved this task from Up Next to Design-Systems-Sprint-4 on the Design-System-Team board.Jul 24 2023, 5:17 PM
egardner edited projects, added Design-System-Team (Design-Systems-Sprint-4); removed Design-System-Team.
egardner moved this task from Design-Systems-Sprint-4 to Up Next on the Design-System-Team board.Jul 24 2023, 5:20 PM
egardner edited projects, added Design-System-Team; removed Design-System-Team (Design-Systems-Sprint-4).
• Catrope moved this task from Up Next to Design-Systems-Sprint-6 on the Design-System-Team board.Aug 14 2023, 5:16 PM
• Catrope edited projects, added Design-System-Team (Design-Systems-Sprint-6); removed Design-System-Team.
• Catrope claimed this task.Aug 15 2023, 6:22 PM
• Catrope moved this task from Committed to In Progress on the Design-System-Team (Design-Systems-Sprint-6) board.
gerritbot added a comment.Aug 17 2023, 1:09 AM

Change 817814 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] Button, Tabs: Factor out common slot content analysis code

https://gerrit.wikimedia.org/r/817814

gerritbot added a project: Patch-For-Review.Aug 17 2023, 1:09 AM

Change 949608 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] Button: Move icon-only check into buttonHelpers

https://gerrit.wikimedia.org/r/949608

gerritbot added a comment.Aug 17 2023, 1:09 AM

Change 949609 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] ToggleButton: Add icon-only detection

https://gerrit.wikimedia.org/r/949609

• Catrope moved this task from In Progress to Code Review on the Design-System-Team (Design-Systems-Sprint-6) board.Aug 17 2023, 1:09 AM
gerritbot added a comment.Aug 18 2023, 6:20 PM

Change 950199 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] Button: Factor out warn-once logic into new useWarnOnce composable

https://gerrit.wikimedia.org/r/950199

gerritbot added a comment.Aug 22 2023, 8:49 PM

Change 817814 merged by jenkins-bot:

[design/codex@main] Button, Tabs: Factor out common slot content analysis code

https://gerrit.wikimedia.org/r/817814

gerritbot added a comment.Aug 22 2023, 11:10 PM

Change 949608 merged by jenkins-bot:

[design/codex@main] Button: Move icon-only check into its own composable

https://gerrit.wikimedia.org/r/949608

gerritbot added a comment.Aug 22 2023, 11:10 PM

Change 950199 merged by jenkins-bot:

[design/codex@main] useIconOnlyButton: Factor out warn-once logic into new useWarnOnce composable

https://gerrit.wikimedia.org/r/950199

gerritbot added a comment.Aug 22 2023, 11:36 PM

Change 949609 merged by jenkins-bot:

[design/codex@main] ToggleButton: Add icon-only detection

https://gerrit.wikimedia.org/r/949609

Maintenance_bot removed a project: Patch-For-Review.Aug 23 2023, 12:10 AM
Volker_E moved this task from Code Review to Design Sign-Off on the Design-System-Team (Design-Systems-Sprint-6) board.Aug 23 2023, 5:08 AM
bmartinezcalvo moved this task from Design Sign-Off to Pending Release on the Design-System-Team (Design-Systems-Sprint-6) board.Aug 23 2023, 10:45 AM

Design sign-off done, it LGTM. The only thing we should fix is the alignment of the icon within the button, but I guess this is part of a separate task. So moving this task to Pending Release.

gerritbot added a comment.Aug 29 2023, 9:20 PM

Change 953351 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.17.0 to v0.18.0

https://gerrit.wikimedia.org/r/953351

gerritbot added a project: Patch-For-Review.Aug 29 2023, 9:21 PM
gerritbot added a comment.Aug 29 2023, 9:46 PM

Change 953351 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.17.0 to v0.18.0

https://gerrit.wikimedia.org/r/953351

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2023, 10:13 PM
• Catrope closed this task as Resolved.Aug 30 2023, 5:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits