Maniphest T317452

[Regression] Breadcrumb links and redirect indicators are abutting
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Quiddity
	Sep 9 2022, 11:06 PM

Tags

Referenced Files

	F35543155: Screen Shot 2022-10-01 at 11.32.51 AM.png
	Oct 1 2022, 6:37 PM

	F35543154: Screen Shot 2022-10-01 at 11.33.41 AM.png
	Oct 1 2022, 6:37 PM

	F35515479: image.png
	Sep 9 2022, 11:06 PM

Subscribers

Masumrezarock100

Description

Steps to replicate the issue (include links if applicable):

Go to a link that redirects to another page, where the 2nd page is a subpage
- e.g. https://meta.wikimedia.org/wiki/Tech/News/Next

What happens?:

The (Redirected from [...]) message is abutting the breadcrumb links for the parent-page(s)

What should have happened instead?:

There should be either
- a linebreak (as in Vector)
- a space (for visual separation)
- or similar

Screenshots (Vector & Vector-2022)

image.png (466×597 px, 46 KB)

Developer notes

The subpages element is currently a span element. Let's switch that to a div element since that seems a more sensible default given how it is used in Wikimedia skins. This requires a change to Skin.php

https://phabricator.wikimedia.org/T317452#8277902

QA Results - Prod

AC	Status	Details
1	✅	T301584#7864568

Details

	Subject	Repo	Branch	Lines +/-
	Change subpages element from <span> to <div>	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: T301584: Add rich snippet instrument to WikimediaEvents
T256932: Evaluate whether #contentSub should contain block children
T316027: [Technical] ResourceLoaderSkinModule: Split up interface features
rSVECdfede899d65a: Reduce dependency on core styles

Event Timeline

Quiddity created this task.Sep 9 2022, 11:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2022, 11:06 PM

Related: T256932
Regression caused by dfede899d (T316027) - the siteSub rule was not copied over.
To fix this it seems sensible to make siteSub a div inside core to fix this one includes/skins/Skin.php to avoid this happening again.

ovasileva triaged this task as High priority.Sep 13 2022, 2:50 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 13 2022, 5:21 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)

LGoto set the point value for this task to 2.Sep 13 2022, 5:27 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Jdrewniak claimed this task.Sep 20 2022, 3:40 PM

Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Change 833413 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/core@master] Change subpages element from <span> to <div>

https://gerrit.wikimedia.org/r/833413

gerritbot added a project: Patch-For-Review.Sep 20 2022, 4:04 PM

Jdlrobson reassigned this task from Jdrewniak to Edtadros.Sep 20 2022, 4:11 PM

Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Jdlrobson added a subscriber: Jdrewniak.

Change 833413 merged by jenkins-bot:

[mediawiki/core@master] Change subpages element from <span> to <div>

https://gerrit.wikimedia.org/r/833413

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2022, 4:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 20 2022, 5:00 PM

Jdlrobson moved this task from Backlog to Milestone: More flexibility in article heading area (subpages, descriptions) on the MediaWiki-Core-Skin-Architecture board.Sep 30 2022, 12:37 AM

Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 30 2022, 11:51 PM

Test Result - Prod

Status: ✅ PASS
Environment: metawiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The subpages element should be switched to a div element.

Screen Shot 2022-10-01 at 11.33.41 AM.png (861×707 px, 181 KB)

Screen Shot 2022-10-01 at 11.32.51 AM.png (767×860 px, 179 KB)

Edtadros updated the task description. (Show Details)Oct 1 2022, 6:37 PM

Looks good, resolving

Jdlrobson merged a task: T270872: Subpages class treated differently in Minerva/Mobile.Mar 12 2024, 11:15 PM

Jdlrobson added subscribers: XanonymusX, hgzh, Masumrezarock100.