[go: nahoru, domu]

Page MenuHomePhabricator

User can't tab out of non-article surface (e.g. DiscussionTools) when document contains tab-indexed content (e.g. a link in a template)
Closed, ResolvedPublic

Description

In T172694 we allowed Tab/Shift+Tab to run natively if indentation command are not available (e.g. in DiscussionTools). However relying on native tabIndexes means that the next focusable element is chosen, even it is within the surface. This leads to confusing or broken behaviour, e.g. if the next focusable is a link in a template, such as you get when you @-mention, focus is not moved at all. Or focus could be moved to the next image caption as that has contenteditable=true set explicitly.

We should instead move focus to the next focusable element outside of the surface, like you would expect a <textarea> to behave.

  1. Start a reply in visual mode
  2. @-mention another user
  3. Press tab

Expected:
Focus moves to the "Advanced" button

Observed:
Nothing happens

Event Timeline

Change 937458 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I8701829: Manually move focus when tab/shift+tab pressed

https://gerrit.wikimedia.org/r/937458

Change 937458 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I8701829: Manually move focus when tab/shift+tab pressed

https://gerrit.wikimedia.org/r/937458

Change 943525 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c1420586c)

https://gerrit.wikimedia.org/r/943525

Change 943525 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c1420586c)

https://gerrit.wikimedia.org/r/943525