Logo, wordmark and tagline should always respect variants defined in the config
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Func
	Jul 8 2024, 5:30 PM

Description

Follow-up to T261153.

The @logo-wordmark-url variable for mediawiki.skinning/logo.less
Wordmark of the Timeless skin
https://codesearch.wmcloud.org/deployed/?q=getAvailableLogos

Details

	Subject	Repo	Branch	Lines +/-
	Pass language code to get logos	mediawiki/skins/Timeless	master	+1 -1
	SkinModule: Always pass language code to get logos	mediawiki/core	master	+10 -6

Customize query in gerrit

Related Objects

Mentioned Here: T261153: Chinese Wikipedia’s wordmark and tagline should change based on variant selection

Event Timeline

Func created this task.Jul 8 2024, 5:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2024, 5:30 PM

Func renamed this task from The `@logo-wordmark-url` variable for `mediawiki.skinning/logo.less` should be varied by user language to Logo, wordmark and tagline should always respect variants defined in the config.Jul 8 2024, 5:44 PM

Func updated the task description. (Show Details)

Change #1052795 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SkinModule: Always pass language code to get logos

https://gerrit.wikimedia.org/r/1052795

gerritbot added a project: Patch-For-Review.Jul 8 2024, 6:00 PM

Func updated the task description. (Show Details)Jul 8 2024, 6:01 PM

Change #1053031 had a related patch set uploaded (by Func; author: Func):

[mediawiki/skins/Timeless@master] Pass language code to get logos

https://gerrit.wikimedia.org/r/1053031

Change #1052795 merged by jenkins-bot:

[mediawiki/core@master] SkinModule: Always pass language code to get logos

https://gerrit.wikimedia.org/r/1052795

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 10 2024, 1:00 AM

Change #1053031 merged by jenkins-bot: