OOUI progressive buttons are the wrong color in dark mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 9 2024, 8:40 PM

Description

Revealed during QA in T365509#9965955

Steps to replicate the issue (include links if applicable):

Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Polar_bear&minervanightmode=1
Check color contrast on page

What happens?:
{F56317349}

What should have happened instead?:
The background is using var(--color-progressive,#36c) rather than var(--background-color-progressive,#36c)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

It is not a problem on light theme
https://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Polar_bear?minervanightmode=0

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.50.4	mediawiki/core	master	+110 -67
	WikimediaUI theme: Update background color in button mixins	oojs/ui	master	+16 -2

Customize query in gerrit

Related Objects

Mentioned In: T365509: Enable night mode on talk page namespaces
Mentioned Here: T365509: Enable night mode on talk page namespaces

Event Timeline

Jdlrobson created this task.Jul 9 2024, 8:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2024, 8:40 PM

Jdlrobson mentioned this in T365509: Enable night mode on talk page namespaces.Jul 9 2024, 8:45 PM

CCiufo-WMF renamed this task from OOUI buttons are using color progressive token rather than background color progressive token to OOUI progressive buttons are the wrong color in dark mode.Jul 10 2024, 8:54 PM

CCiufo-WMF updated the task description. (Show Details)

CCiufo-WMF moved this task from Inbox to Triaging on the Design-System-Team board.