Maniphest T369702

Existing statements using deleted properties break certain endpoints
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jakob_WMDE
	Jul 10 2024, 10:57 AM

Tags

Referenced Files

None

Subscribers

Description

Similar to T368935 but for statements referring to deleted properties. [Endpoints affected PATCH property & PATCH item]

Reproduction steps:

create statement to any page
delete the property the statement refers to (or any of the qualifier/reference properties)

Possible solution: Validating only statements that actually changed would fix this and is probably a good idea anyway (for performance).

Details

	Subject	Repo	Branch	Lines +/-
	REST: Create to be deleted property first in e2e test	mediawiki/extensions/Wikibase	master	+33 -25
	REST: Fix unmodified statement detection in validator	mediawiki/extensions/Wikibase	master	+20 -1
	REST: Validate only modified statements	mediawiki/extensions/Wikibase	master	+293 -67
	REST: Remove StatementsDeserializer	mediawiki/extensions/Wikibase	master	+150 -314

Customize query in gerrit

Related Objects

Mentioned Here: T368935: Sitelinks to deleted pages break certain endpoints

Event Timeline

Jakob_WMDE created this task.Jul 10 2024, 10:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2024, 10:57 AM

Jakob_WMDE added a project: Wikibase REST API (WPP).Jul 10 2024, 10:58 AM

Ifrahkhanyaree_WMDE moved this task from Backlog to To polish on the Wikibase Product Platform Team WPP board.Jul 18 2024, 7:35 AM

Ifrahkhanyaree_WMDE moved this task from To polish to Polished on the Wikibase Product Platform Team WPP board.Jul 18 2024, 12:38 PM

Ifrahkhanyaree_WMDE updated the task description. (Show Details)Mon, Jul 22, 9:35 AM

Ifrahkhanyaree_WMDE set the point value for this task to 5.

Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.

Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 25 on the Wikibase Product Platform Team WPP board.Tue, Jul 23, 9:44 AM

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 25); removed Wikibase Product Platform Team WPP.

Ifrahkhanyaree_WMDE moved this task from Backlog to Next on the Wikibase REST API (WPP) board.Fri, Jul 26, 2:40 PM

Jakob_WMDE claimed this task.Mon, Jul 29, 8:29 AM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 25) board.

Change #1058631 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove StatementsDeserializer

https://gerrit.wikimedia.org/r/1058631

gerritbot added a project: Patch-For-Review.Wed, Jul 31, 3:39 PM

Change #1059401 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Validate only modified statements

https://gerrit.wikimedia.org/r/1059401

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 25) board.Mon, Aug 5, 8:32 AM

Change #1058631 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove StatementsDeserializer

https://gerrit.wikimedia.org/r/1058631

Change #1059401 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate only modified statements

https://gerrit.wikimedia.org/r/1059401

Silvan_WMDE moved this task from Peer Review to Product Verification on the Wikibase Product Platform Team WPP (Sprint 25) board.Mon, Aug 5, 3:20 PM

Maintenance_bot removed a project: Patch-For-Review.Mon, Aug 5, 3:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Mon, Aug 5, 4:00 PM

Change #1060072 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Fix unmodified statement detection in validator

https://gerrit.wikimedia.org/r/1060072

gerritbot added a project: Patch-For-Review.Tue, Aug 6, 8:52 AM

Jakob_WMDE moved this task from Product Verification to Peer Review on the Wikibase Product Platform Team WPP (Sprint 25) board.Tue, Aug 6, 9:01 AM

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 26); removed Wikibase Product Platform Team WPP (Sprint 25).Tue, Aug 6, 10:21 AM

Ifrahkhanyaree_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform Team WPP (Sprint 26) board.

Change #1060072 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Fix unmodified statement detection in validator

https://gerrit.wikimedia.org/r/1060072

Jakob_WMDE moved this task from Peer Review to Product Verification on the Wikibase Product Platform Team WPP (Sprint 26) board.Wed, Aug 7, 9:10 AM

Maintenance_bot removed a project: Patch-For-Review.Wed, Aug 7, 9:30 AM

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.18; 2024-08-13); removed MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Wed, Aug 7, 10:00 AM

Change #1060444 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Create to be deleted property first in e2e test

https://gerrit.wikimedia.org/r/1060444

gerritbot added a project: Patch-For-Review.Wed, Aug 7, 1:53 PM

Change #1060444 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Create to be deleted property first in e2e test

https://gerrit.wikimedia.org/r/1060444

Maintenance_bot removed a project: Patch-For-Review.Wed, Aug 7, 4:30 PM

Ifrahkhanyaree_WMDE moved this task from Product Verification to Done on the Wikibase Product Platform Team WPP (Sprint 26) board.Fri, Aug 9, 11:10 AM

Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Aug 20, 10:01 AM