Change Details

The line: ``` local ispreview = frame:preprocess( "{{REVISIONID}}" ) == "" and 1 or 0 ``` is extremely bad for performance since: a) it disables edit stashing on any page that uses this template (e.g. via infoboxes). b) it causes a double parse on edit due to var-revision in doEditUpdates() Maybe a dedicated {{PREVIEWMODE}} word can be added instead? Edit stash graphs: https://grafana.wikimedia.org/dashboard/db/edit-stash I suspect most of the "uncacheable" sector of the pie is from this. List of main enwiki templates doing this: * Module:Check for unknown parameters * Module:Convert * Module:Citation/CS1 * Module:TemplatePar * Module:Check_for_unknown_parameters

The line: ``` local ispreview = frame:preprocess( "{{REVISIONID}}" ) == "" and 1 or 0 ``` is extremely bad for performance since: a) it disables edit stashing on any page that uses this template (e.g. via infoboxes). b) it causes a double parse on edit due to var-revision in doEditUpdates() Maybe a dedicated {{PREVIEWMODE}} word can be added instead? Edit stash graphs: https://grafana.wikimedia.org/dashboard/db/edit-stash I suspect most of the "uncacheable" sector of the pie is from this. List of main enwiki templates doing this: * Module:Check for unknown parameters * Module:Convert * Module:Citation/CS1 * Module:TemplatePar

The line: ``` local ispreview = frame:preprocess( "{{REVISIONID}}" ) == "" and 1 or 0 ``` is extremely bad for performance since: a) it disables edit stashing on any page that uses this template (e.g. via infoboxes). b) it causes a double parse on edit due to var-revision in doEditUpdates() Maybe a dedicated {{PREVIEWMODE}} word can be added instead? Edit stash graphs: https://grafana.wikimedia.org/dashboard/db/edit-stash I suspect most of the "uncacheable" sector of the pie is from this. List of main enwiki templates doing this: * Module:Check for unknown parameters * Module:Convert * Module:Citation/CS1 * Module:TemplatePar * Module:Check_for_unknown_parameters