d7b2599285cf0affd6013a58497ff5fabdf41125 |
|
19-Apr-2016 |
Alan Viverette <alanv@google.com> |
Don't overwrite vertical and horizontal offsets unless explicit Bug: 28194522 Change-Id: I14c8b719a0fca03da6d9834d07948a5513241b26
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
7ce082a46259e948e4ea6a12f327f32aecaf167a |
|
08-Apr-2016 |
Oren Blasberg <orenb@google.com> |
Merge "Fix top level menu lingering when submenu opens." into nyc-dev
|
ddf6b8130f62c82241544bef19bcee4ef3171a82 |
|
06-Apr-2016 |
Oren Blasberg <orenb@google.com> |
Fix icon spacing on both MenuPopup implementations. Ensure we calculate based on the actual menu items in a particular menu or submenu, not based on whether the parent menu had icon spacing enabled. Bug: 28026351 Change-Id: Ie6e56eb142f0b82de38bf39ee848ddd26df2bf1c
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
9022c7129ec763c9485f3a2de67b1e19eb77f462 |
|
05-Apr-2016 |
Oren Blasberg <orenb@google.com> |
Fix top level menu lingering when submenu opens. We should be calling close(false), not dismiss(), when the submenu is opened. This change brings the code closer to what it was before the prior change to StandardMenuPopup, but preserves the ondismiss behavior we want for popup menus. The net change so far is that StandardMenuPopup, not MenuBuilder#performItemAction, handles closing the top level menu when a submenu is opened. But nonetheless, the onDismiss is not called when a submenu is opened; only when an actual real "dismiss" occurs. Bug: 28001958 Change-Id: Ia0f89f8fd4bc5494f6a048c993792adfe42d88ec
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
4348688ed351e32ac6c478deb92be7579a1131ea |
|
28-Mar-2016 |
Oren Blasberg <orenb@google.com> |
Call the onDismiss listener in submenus. For StandardMenuPopup, if user opens a submenu, the ondismiss listener is no longer called. Instead, it is called when the submenu (which is now open in the top level menu's place) is dismissed. Bug: 27877103 Change-Id: I069388fd173142620c667fa8d1cb21e88d5266fe
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
64b715736847ca53864e86b78e94b685ada0e5c8 |
|
28-Jan-2016 |
Alan Viverette <alanv@google.com> |
Don't move non-modal popups in response to global layout Bug: 26799074 Change-Id: Id363342f65b89c624f672ec0276408003e41008f
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
91098574f90277128415e9593cce1e495cc51465 |
|
19-Jan-2016 |
Alan Viverette <alanv@google.com> |
Animate context popup menu around origin point Also enables the context popup menu enter transition. Bug: 25801140 Change-Id: Id7fb384e8ac8974189b32a052352bd2f6cbb176e
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
02cd0f91059f04136bb3817b41305c2909f4f1d5 |
|
13-Jan-2016 |
Alan Viverette <alanv@google.com> |
Clean up lint warnings in popup menu presenter classes Change-Id: I6b4cce1c4788b408615af0c93575e02e75b4c3ca
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
77fb85eda9923970d6f8f699e8d628d37c3dd764 |
|
14-Dec-2015 |
Alan Viverette <alanv@google.com> |
Only handle Context submenus as dialogs when parent is a dialog Bug: 25656520 Change-Id: I5841d8f0c3d4a537e2d94aacddb1687d05d5c258
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
021627eb5875372dea57ba91fa782fffbfbbc559 |
|
25-Nov-2015 |
Alan Viverette <alanv@google.com> |
Ensure only one context menu is shown at a time Refactors the menu helper classes. Both classes now implement a common MenuHelper interface, which eliminates the need to keep separate helpers on PhoneWindow and unifies the DecorView showContextMenuForChild() implementations. We now explicitly dismiss any previously shown context menu before showing a new context menu. Previously we relied on the modal nature of the dialog context menu to prevent multiple menus from being opened at once, but this is no longer reliable with popup context menus. Bug: 25656520 Change-Id: Idab3daa6d6888f803f2e33660fe1dd488e4c28d1
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
ed3912692f0ba8a647d795462e20fcdb67adbacb |
|
01-Sep-2015 |
Oren Blasberg <orenb@google.com> |
Make context menus show as popup menus. This means that right-clicking/long pressing on a view that is registered for context menu will show the context menu as a popup menu instead. Bug: 20016398 Change-Id: I96fea60435fff2f981d288521f490f8ff24ada15
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
23087be7792c2d22173cf022a72d0648aa430ab5 |
|
08-Sep-2015 |
Oren Blasberg <orenb@google.com> |
Cascading popup menus: open submenu on mouse hover. When the cascading feature is enabled, users can mouseover a submenu item in a popup menu to expand and open the new submenu (after a short timeout). Similarly, if a user mouseovers a different menu item in the original menu, the submenu gets closed (again, after a short timeout). This should complete the implementation of cascading submenu functionality. Also fix two other issues: (1) Update some oudated code in PopupMenu that was still opening the submenu when a user clicks on a submenu item; this responsibility now lives within the MenuPopupHelper's delegate MenuPopup class, so it doesn't need to live in PopupMenu anymore. (2) Fix an issue where icons would be force-set on a submenu when they should not be. Instead, decide whether to show icons in a submenu based on whether to show them in the top level menu, as intended. Bug: 20127825 Change-Id: Ia46852c7f99436065ab4bc234de94dffc0019666
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
9916282bac8ac8fab7ce5b649c049842acffa29b |
|
10-Sep-2015 |
Oren Blasberg <orenb@google.com> |
Fix broken popup menu in Shelf (andromeda). This addresses a few oversights from an earlier CL: 1. In MenuPopupHelper#show() make sure to create a new MenuPopup in case the earlier one was dismissed. 2. Ensure the on-dismiss listener gets called even if the MenuPopupHelper's MenuPopup was previously closed and if a new one is opened. 3. Handle global layout changes properly by having the MenuPopup re-drawing/positioning itself. Bug: 23973158 Change-Id: Iee866079770026f0fe17814892abc9825f9760a2
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|
b23976efdd6ffe42cb3b8fe6650fc77bd9a161e8 |
|
01-Sep-2015 |
Oren Blasberg <orenb@google.com> |
MenuPopupHelper: Factor out a MenuPopup interface. Move much of the responsibility into implementations of this interface. Delegate functionality to it where appropriate. Provide a standard (non-cascading) implementation for this interface. This CL should have NO BEHAVIOR CHANGES. A follow-up CL will provide a cascading implementation, whereby a config variable will enable submenus to open side by side with their parent menus. That CL will be the first with functional/ actual behavior changes. Bug: 20127825 Change-Id: Iecac2d340dd8750ebe4e99162d447c9411f09227
/frameworks/base/core/java/com/android/internal/view/menu/StandardMenuPopup.java
|