9380e112f7b9ab83b57062f2164476e76c5533c7 |
|
04-Sep-2014 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
[media] hdpvr: reduce memory footprint when debugging There is no need to use hex_dump_to_buffer() since we have a kernel helper to dump up to 64 bytes just via printk(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
|
1ba6c90161ac058f580e6ceb5ccc14dcd86365d1 |
|
17-Jan-2014 |
Masanari Iida <standby24x7@gmail.com> |
[media] hdpvr: Fix memory leak in debug cppcheck reported memory leak in device_authorizatio() within hdpvr-core.c. When the debug option is specified and the code jump to "unlock:" label, print_buf was not freed. Confirm the module succesfully compiled without error. Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
c8e479c48326d3c2dbd55e61f0da00694df472a8 |
|
04-Oct-2013 |
Hans Verkuil <hans.verkuil@cisco.com> |
[media] hdpvr: fix sparse warnings drivers/media/usb/hdpvr/hdpvr-core.c:110:54: warning: incorrect type in argument 1 (different base types) drivers/media/usb/hdpvr/hdpvr-core.c:112:39: warning: invalid assignment: += drivers/media/usb/hdpvr/hdpvr-core.c:304:26: warning: Using plain integer as NULL pointer Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
2e923a0527ac439e135b9961e58d3acd876bba10 |
|
03-Jul-2013 |
Alexey Khoroshilov <khoroshilov@ispras.ru> |
[media] hdpvr: fix iteration over uninitialized lists in hdpvr_probe() free_buff_list and rec_buff_list are initialized in the middle of hdpvr_probe(), but if something bad happens before that, error handling code calls hdpvr_delete(), which contains iteration over the lists (via hdpvr_free_buffers()). The patch moves the lists initialization to the beginning and by the way fixes goto label in error handling of registering videodev. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> Cc: stable@vger.kernel.org
|
e2f11c58ae49d57b0e634685dd944c1771ba38c0 |
|
03-Jul-2013 |
Alexey Khoroshilov <khoroshilov@ispras.ru> |
[media] hdpvr: fix iteration over uninitialized lists in hdpvr_probe() free_buff_list and rec_buff_list are initialized in the middle of hdpvr_probe(), but if something bad happens before that, error handling code calls hdpvr_delete(), which contains iteration over the lists (via hdpvr_free_buffers()). The patch moves the lists initialization to the beginning and by the way fixes goto label in error handling of registering videodev. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
ccc40ed7555d053f60328e9742e559fb75e85002 |
|
25-Apr-2013 |
Leonid Kegulskiy <leo@lumanate.com> |
[media] hdpvr: Removed unnecessary get_video_info() call from hdpvr_device_init() Signed-off-by: Leonid Kegulskiy <leo@lumanate.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
c7a2c84af549572c454a8d79011c7fac72b3e53d |
|
20-Mar-2013 |
Hans Verkuil <hans.verkuil@cisco.com> |
[media] hdpvr: recognize firmware version 0x1e This is the latest firmware version and - it seems - the most reliable. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
280847b532433ffe7a22795f926327805a127162 |
|
19-Mar-2013 |
Hans Verkuil <hans.verkuil@cisco.com> |
[media] hdpvr: register the video node at the end of probe Video nodes can be used at once after registration, so make sure the full initialization is done before registering them. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
972b072a83316e0d5a1fd0cb78eb99a57a305dce |
|
24-Feb-2013 |
Syam Sidhardhan <syamsidhardh@gmail.com> |
[media] hdpvr: Fix memory leak This patch fixes the print_buf leaking. Signed-off-by: Syam Sidhardhan <s.syam@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
9ecf9b085a0926e07c78c08a07296bbfd1c37d07 |
|
19-Jan-2013 |
Peter Senna Tschudin <peter.senna@gmail.com> |
[media] [V2,22/24] usb/hdpvr/hdpvr-core.c: use IS_ENABLED() macro replace: #if defined(CONFIG_I2C) || \ defined(CONFIG_I2C_MODULE) with: #if IS_ENABLED(CONFIG_I2C) This change was made for: CONFIG_I2C Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
304a0807a22852fe3095a62c24b25c4d0e16d003 |
|
06-Sep-2012 |
Peter Senna Tschudin <peter.senna@gmail.com> |
[media] drivers/media/usb/hdpvr/hdpvr-core.c: fix error return code Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
0c0d06cac63ee327ceaab4b5ffe2206574ab86bd |
|
14-Aug-2012 |
Mauro Carvalho Chehab <mchehab@redhat.com> |
[media] rename most media/video usb drivers to media/usb Rename all USB drivers with their own directory under drivers/media/video into drivers/media/usb and update the building system. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|