| 8e3489f3b6c159079cf690d0913409e1178ccf2f |
|
03-Jun-2014 |
Jingoo Han <jg1.han@samsung.com> |
spi: sh-hspi: Make of_device_id array const
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 4a4dd7d80e11f62cacf49bd90d9448a218188af7 |
|
14-Apr-2014 |
Simon Horman <horms+renesas@verge.net.au> |
spi: sh-hspi: Do not specifically request shyway_clk clock
Rather than requesting the shyway_clk call clk_get with
the device and a NULL con_id.
This is in keeping with the way that clk_get() is called
on other drivers used by Renesas Gen 1 SoCs. And I believe
it is compatible with supplying clocks via DT, unlike the current code.
It appears to me that the two uses of this driver are
the r8a7778 and r8a7779 SoCs.
The r8a7779 already has clocks setup to allow this driver to continue to work
with this change applied.
The r8a7778 has clocks incorrectly setup to allow this driver to continue
to work with this change applied. This problem is addressed in
"ARM: shmobile: r8a7778: Use clks as MSTP007 parent" which is thus
a pre-requisite of this patch.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 3abf0edd2c16326727326c35704ab9cad0529eda |
|
11-Mar-2014 |
Geert Uytterhoeven <geert+renesas@linux-m68k.org> |
spi: sh-hspi: Add missing call to pm_runtime_disable() in failure path
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| e428a420078eac26039b53af464355332809be52 |
|
02-Mar-2014 |
Axel Lin <axel.lin@ingics.com> |
spi: sh-hspi: Remove duplicate code to set default transfer speed
In the implementation of __spi_validate(), spi core will use spi device's max
speed as default transfer speed if it is not set for this transfer.
So we can remove the same logic in hspi_hw_setup().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 80d68ca5a52176a140e1daa527d0b698feb69c83 |
|
27-Feb-2014 |
Axel Lin <axel.lin@ingics.com> |
spi: sh-hspi: Remove hspi_cleanup function
hspi_cleanup() is doing nothing except print a non-useful debug message,
so remove it. Also remove unused hspi2info macro.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 4522193698d115761f9e4f340697f86975ac8e69 |
|
12-Feb-2014 |
Axel Lin <axel.lin@ingics.com> |
spi: sh-hspi: Convert to let spi core validate bits_per_word
Set bits_per_word_mask so spi core will reject transfers that attempt to use
an unsupported bits_per_word value.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 78e39523b8c9721250b54b7fd930aeced56cf511 |
|
11-Feb-2014 |
Axel Lin <axel.lin@ingics.com> |
spi: Remove explictly set bus_num and num_chipselect to default setting
The purpose of commit 1e8a52e18cfb
"spi: By default setup spi_masters with 1 chipselect and dynamics bus number"
is to avoid setting default value for bus_num and num_chipselect in spi master
drivers. So let's remove the duplicate code.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-By: David Daney <david.daney@cavium.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| c6c07b4f6d697cab021ca07de21c4c0da2ac47b1 |
|
12-Jan-2014 |
Geert Uytterhoeven <geert+renesas@linux-m68k.org> |
spi: sh-hspi: Spelling s/recive/receive/
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| caedb997a400ab50da201dd415c3ef7cce016437 |
|
08-Jan-2014 |
Axel Lin <axel.lin@ingics.com> |
spi: sh-hspi: Fix modalias for sh-hspi
Make the modalias matches the driver name.
Seems the MODULE_ALIAS is copied from drivers/spi/spi-sh-spi.c.
So both spi-sh.ko and spi-sh-hspi.ko have the same alias. Fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| e5f7825cda366809153701e8bb89123bd973be00 |
|
25-Oct-2013 |
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
spi/hspi: add device tree support
Support for loading the Renesas HSPI driver via devicetree.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| a29c8ae7187aee902d37d7677255de726614e43e |
|
14-Oct-2013 |
Jingoo Han <jg1.han@samsung.com> |
spi: sh-hspi: Fix checkpatch issue
Fix the following checkpatch warning.
WARNING: space prohibited before semicolon
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 268d76430d1b68c340687357ffd18b4b12d02269 |
|
03-Oct-2013 |
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
spi/hspi: fixup Runtime PM enable timing
3e00a09d2fbd64f0ad98e7c8c29dbf9e038fc746
(spi/hspi: Convert to core runtime PM)
enabled master->auto_runtime_pm.
Then, pm_runtime_enable() is required *before*
spi_register_master() calling.
This patch fixed it up.
Kernel will hang up with "spi_master spi0: Failed to power device: -13"
message without this patch.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 1c43f2ae1ee3b04f7466e31a59b19b7fa5fe4fc2 |
|
24-Sep-2013 |
Jingoo Han <jg1.han@samsung.com> |
spi: sh-hspi: use devm_spi_register_master()
Use devm_spi_register_master() to make cleanup paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 3e00a09d2fbd64f0ad98e7c8c29dbf9e038fc746 |
|
28-Jul-2013 |
Mark Brown <broonie@linaro.org> |
spi/hspi: Convert to core runtime PM
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| 8e76fda3e1ea73bc47189ebc49d4228ec86fb1fa |
|
28-Jul-2013 |
Mark Brown <broonie@linaro.org> |
spi/sh-hspi: Remove noisy print
This adds no meaningful value.
Signed-off-by: Mark Brown <broonie@linaro.org>
|
| bc2bfffc3866e8c87dde19d5619262a810a51ed8 |
|
27-May-2013 |
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
spi: hspi: fixup long delay time
Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
but it was too long delay for SPI device.
Bock-W board SPI access was too slow without this patch.
This patch uses udelay(10) for it.
Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
|
| 24b5a82cf5709a4bc577f42fdaa61b23a7f58f08 |
|
23-May-2013 |
Jingoo Han <jg1.han@samsung.com> |
spi: use platform_{get,set}_drvdata()
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
|
| d3601e56cf64a3f2df6f6380cccb3644274406e2 |
|
12-Dec-2012 |
Cyril Roelandt <tipecaml@gmail.com> |
spi/sh-hspi: fix return value check in hspi_probe().
According to its documentation, clk_get() returns a "valid IS_ERR() condition
containing errno", so we should call IS_ERR() rather than a NULL check.
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
|
| fd4a319bc933ae93e68935b21924a9ca4ba2d060 |
|
07-Dec-2012 |
Grant Likely <grant.likely@secretlab.ca> |
spi: Remove HOTPLUG section attributes
CONFIG_HOTPLUG is going away as an option. As result the __dev*
markings will be going away.
Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.
Bill Pemberton has done most of the legwork on this series. I've used
his script to purge the attributes from the drivers/gpio tree.
Reported-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
|
| ce3293058637ada3b1837a77c8f9c672a51b2434 |
|
22-Nov-2012 |
Phil Edworthy <phil.edworthy@renesas.com> |
spi/sh-hspi: add CS manual control support
The current HSPI driver used automatic CS control, leading to CS
active for each byte transmitted. This patch changes the driver
to manual CS control, and ensures CS is active thoughout a whole
message. Additionally, it uses the cs_change field to determine
if CS is disabled between transfers in the message.
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
|
| 78bfee0e1e2e22c3062b41be8db618e7484c8e35 |
|
01-Sep-2012 |
Julia Lawall <Julia.Lawall@lip6.fr> |
spi: spi-sh-hspi: drop frees of devm_ alloc'd data
devm free functions should not have to be explicitly used.
A semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
@@
(
* devm_kfree(...);
|
* devm_free_irq(...);
|
* devm_iounmap(...);
|
* devm_release_region(...);
|
* devm_release_mem_region(...);
)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
|
| bb9c5687e8cd02d6f8a3aea40c118b439cb09501 |
|
14-Mar-2012 |
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
spi: sh-hspi: modify write/read method
Current sh-hspi had wrong write/read method which was not linux standard.
If spi_transfer requests tx[2], rx[2] len=2,
then, driver should run tx[0], rx[0], tx[1], rx[1].
But current sh-hspi runs tx[0], tx[1], rx[0], rx[1].
This patch fixes it up.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
|
| 49e599b8595f9d33276860c6a02e05f240c4ceca |
|
14-Mar-2012 |
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
spi: sh-hspi: control spi clock more correctly
Current sh-hspi had used platform-specific speed.
This patch remove it, and use spi_transfer specific speed.
It removes unnecessary flags from struct sh_hspi_info,
but struct sh_hspi_info is still exist, since sh-hspi needs
platform info in the future.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
|
| ec139b67ad00647239b804d6f15315b83dba9a58 |
|
14-Mar-2012 |
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
spi: sh-hspi: convert to using core message queue
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
|
| d1c8bbd793e4c2f346f8788ad312f5b5b530aff5 |
|
02-Mar-2012 |
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
spi: Add SuperH HSPI prototype driver
This patch adds SuperH HSPI driver.
It is still prototype driver, but has enough function at this point.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
|