Issue 6767003: Using an explicit constructor for courgette:MemoryAllocator is incompatible with the implementati...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6767003: Using an explicit constructor for courgette:MemoryAllocator is incompatible with the implementati... (Closed)

Created:
9 years, 9 months ago by jeanluc1

Modified:
9 years, 4 months ago

Reviewers:
bradnelson, jam, bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Using an explicit constructor for courgette:MemoryAllocator is incompatible with the implementation of basic_string found in VS2010 BUG=71145 TEST=Compile cleanly under VS2010

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	courgette/memory_allocator.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bradn

LGTM I'm working on the bots to prevent regressions. Sorry, about that....

9 years, 9 months ago (2011-03-28 21:18:53 UTC) #2

jam

9 years, 9 months ago (2011-03-28 21:26:06 UTC) #3

lgtm

On Mon, Mar 28, 2011 at 2:18 PM, <bradnelson@google.com> wrote:

> LGTM
>
> I'm working on the bots to prevent regressions. Sorry, about that....
>
>
> http://codereview.chromium.org/6767003/
>

Expand Messages | Collapse Messages