bad A11Y/U7Y in PDF viewer toolbar
Categories
(Firefox :: PDF Viewer, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox130 | --- | affected |
People
(Reporter: mrmazda, Assigned: calixte, NeedInfo)
References
Details
(4 keywords, Whiteboard: [pdfjs-ux])
Attachments
(8 files)
|
138.21 KB,
image/png
|
Details | |
|
235.49 KB,
image/png
|
Details | |
|
422.10 KB,
image/png
|
Details | |
|
44 bytes,
text/x-github-pull-request
|
Details | Review | |
|
44 bytes,
text/x-github-pull-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
49.24 KB,
image/png
|
Details | |
|
44 bytes,
text/x-github-pull-request
|
Details | Review |
Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Firefox/38.0; Build ID: 20150505103531 Actual behavior: 1-toolbar icons too small 2-toolbar text too small 3-neither icons nor text are affected by zoom level 4-neither icons nor text adapt according to display density or other environmental settings 5-neither icons nor text can be adjusted using default theme options Expected behavior: 1-Icons and text automatically sized sensibly regardless of display density and environment, like main menu bar and most other UI text.
| Reporter | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
We should probably move away from pixels for everything and use device pixels or separate styles for different device-pixel-ratio's.
| Reporter | ||
Updated•8 years ago
|
| Reporter | ||
Updated•8 years ago
|
Updated•3 years ago
|
| Reporter | ||
Comment 4•2 years ago
|
||
This screenshot was made using a virgin FF profile.
It has improved, but its text remains arbitrarily smaller than the desktop's UI text, sitting in a sea of whitespace, and its icons remain teensy.
| Assignee | ||
Updated•2 years ago
|
Comment 5•6 months ago
|
||
This is an access-s3 bug per the Accessibility triage guidelines.
Touch/click target size is recommended to be at least 44 x 44 CSS px and to provide sufficient whitespace to avoid clicking a neighbor instead of the target. More on touch target sizes on desktop and mobile can be found in the BBC A11y Guide and in the WCAG 2.2 Success Criterion 2.5.5 Target Size (Enhanced) and Success Criterion 2.5.8 Target Size (Minimum). Also, it is expected that the font of the PDF viewer UI would follow the browser UI and allow to be resized by the user (vaguely refer to SC 1.4.4 Resize Text)
Comment 6•2 months ago
|
||
| Assignee | ||
Updated•2 months ago
|
Comment 7•2 months ago
|
||
| Assignee | ||
Comment 8•2 months ago
|
||
The goal is to be able to change the pdf.js toolbar height depending on the toolbar.density value.
Pushed by cdenizet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6dd3ed97864 Dispatch an event in pdf.js when the pref toolbar.density is changed r=pdfjs-reviewers,marco
Updated•1 month ago
|
Comment 10•1 month ago
|
||
Backed out for causing wpt failures in plugin-document.historical.html
- Backout link
- Push with failures
- Failure Log
- Failure line:TEST-UNEXPECTED-TIMEOUT | /html/browsers/browsing-the-web/navigating-across-documents/plugin-document.historical.html | expected OK
Comment 11•1 month ago
•
|
||
We also have other failures:
geckoview: https://treeherder.mozilla.org/logviewer?job_id=465655758&repo=autoland
Mochitest: TEST-UNEXPECTED-FAIL | toolkit/components/pdfjs/test/test_pdf_file_in_iframe.html | Test timed out. -
TEST-UNEXPECTED-FAIL | toolkit/components/pdfjs/test/test_pdf_file_in_iframe.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once. Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
Possibly this: https://treeherder.mozilla.org/logviewer?job_id=465656835&repo=autoland
Wpt 21: https://treeherder.mozilla.org/logviewer?job_id=465657295&repo=autoland
Fenix: https://treeherder.mozilla.org/logviewer?job_id=465664017&repo=autoland , https://treeherder.mozilla.org/logviewer?job_id=465663929&repo=autoland
I assume all these failures on Android 7.0: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=70c615f711f3c4b76a1863df79f1a7eda6425e68&searchStr=android%2C7.0&selectedTaskRun=AgwBQ1oKQmKs5EVutaq0JA.0
Comment 12•1 month ago
|
||
Hello, we have a number of UI tests PDF tests that started failing on Fenix also prior to back-out (as part of ui-test-apk jobs on the push). They can be scheduled via ./mach try --preset firefox-android as well ran locally when you have Fenix up and running: https://firefox-source-docs.mozilla.org/mobile/android/fenix/UI-Tests.html#running-ui-tests
Comment 13•1 month ago
|
||
In the case for Fenix, all attempts at loading a PDF were stuck and hung (as seen on devices and emulators on Firebase Test Lab).
Comment 14•1 month ago
|
||
Pushed by cdenizet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d98e5190542e Dispatch an event in pdf.js when the pref toolbar.density is changed r=pdfjs-reviewers,marco
Comment 15•1 month ago
|
||
| bugherder | ||
Comment 16•20 days ago
|
||
Updated•15 days ago
|
Comment 17•8 days ago
|
||
Can this be closed now that pdf.js was updated in bug 1911184?
Comment 18•21 hours ago
|
||
Not yet, there is still something left to do here: the patch in this bug (which was backed-out) and https://github.com/mozilla/pdf.js/pull/18385.
Description
•