dom/media/systemservices/MediaSystemResourceManager.cpp:71:33 [-Wshadow] declaration shadows a local variable dom/media/systemservices/MediaUtils.h:85:32 [-Wshadow] declaration shadows a local variable dom/media/systemservices/MediaUtils.h:85:60 [-Wshadow] declaration shadows a local variable dom/media/systemservices/MediaParent.cpp:250:19 [-Wshadow-local] declaration of 'buffer' shadows a previous local dom/media/systemservices/MediaParent.cpp:258:18 [-Wshadow-compatible-local] declaration of 'count' shadows a previous local dom/media/systemservices/MediaParent.cpp:259:18 [-Wshadow-compatible-local] declaration of 'rv' shadows a previous local

Comment on attachment 8752529 [details] [diff] [review] Wshadow_systemservices.patch Review of attachment 8752529 [details] [diff] [review]: ----------------------------------------------------------------- r+ if you read my rant. :-) ::: dom/media/systemservices/MediaUtils.h @@ +82,5 @@ > class Functors : public FunctorsBase > { > public: > + Functors(OnSuccessType&& aOnSuccessRef, OnFailureType&& aOnFailureRef) > + : mOnSuccess(Move(aOnSuccessRef)), mOnFailure(Move(aOnFailureRef)) {} The `Functors` class cannot access the `Then` function parameters&variables anyway, so there's no real shadowing happening. But if that's needed to shut up the compiler, so be it!

Thanks. That's a good point. clang does seem to be a bit overzealous in this case.