Ninoschka Baca Reporter
	Description • 23 years ago

Trunk build 2002-03-20: WinMe, Linux RH 7.1, Mac 10.1.3

Overview: If bug# 132446 is not fixed then the Properties button should be
disabled when multilple cards are selected.

	Ninoschka Baca Reporter
	Comment 1 • 23 years ago

.

	Mark Banner (:standard8)
	Comment 2 • 20 years ago

Adding dependency to bug 37922 as I'll probably be fixing this under that bug.

	Paul Tomlin
	Comment 3 • 18 years ago

Pulling in 37922 and deps onto my task list

	Thomas D. (:thomas8)
	Comment 4 • 10 years ago

Aceman, could you pls test this patch if it fixes the issue?

	:aceman Assignee
	Comment 5 • 10 years ago

Comment on attachment 8425378 [details] [diff] [review]
Patch V.1: Disable Properties button for multiple selections

Review of attachment 8425378 [details] [diff] [review]:
-----------------------------------------------------------------

You do not need the empty Date, Node ID, Parent lines. But add '# ' before 'HG changeset patch'.

The file is in mailnews/addrbook/content/abResultsPane.js, not mailnews/addrbook/resources/content/abResultsPane.js .
But I don't know in which dialog I should try to fix this. We have Properties in Find->Addresses (this works fine without the patch), in Addressbook, in Contacts sidebar in composer. But I didn't notice this would fix it anywhere.

As far as I could debug, your line was never executed in my tests.

I am playing with it a bit and it seems much more involved. But it seems I could do something with it if you wish.

	:aceman Assignee
	Comment 6 • 10 years ago

mconley, can you please check if really this much is needed? I just made the edit/properties buttons/menuitems observe the cmd_properties command. I didn't use the double personality that Delete uses (there are both cmd_delete and button_delete). Not sure what that is for. The /mailnews code now knows both cmd_properties and button_edit because SM uses button_edit.

For me it works now in the addressbook window and also compose contacts sidebar.

	Thomas D. (:thomas8)
	Comment 7 • 10 years ago

Thanks aceman for taking over, which will definitely speed this up in better hands ;) ... I was suspecting something along the lines of your patch because the old code which I swapped out didn't look wrong as such... So I'm glad that my tentative try patch has sparked this off, perhaps I should try that trick more often ;)

	Mike Conley (:mconley) (:⚙️)
	Comment 8 • 10 years ago

Comment on attachment 8425689 [details] [diff] [review]
patch v2

Review of attachment 8425689 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this looks like the right idea.

	:aceman Assignee
	Comment 9 • 10 years ago

Guys, would you like this in SM too? Do you see a need for both cmd_properties and button_edit or can we unify it?

	neil@parkwaycc.co.uk
	Comment 10 • 10 years ago

Comment on attachment 8425689 [details] [diff] [review]
patch v2

>+function CommandUpdate_Addressbook()
...
>+               >
Oops?

>-        return (GetSelectedCardIndex() != -1);
>+        // While "Edit Contact" dialogue is still modal (bug 115904, bug 135126),
>+        // only enable "Properties" button for single selection; then fix bug 119999.
>+        return (GetNumSelectedCards() == 1);
(As it happens GetSelectedCardIndex returns -1 unless the number of selected cards is 1)

	neil@parkwaycc.co.uk
	Comment 11 • 10 years ago

(In reply to aceman from comment #9)
> Guys, would you like this in SM too? Do you see a need for both
> cmd_properties and button_edit or can we unify it?

I don't see any reason not to rename button_edit to cmd_properties.

(I don't know why the delete button is the one element that doesn't observe button_delete...)

	Ian Neal
	Comment 12 • 10 years ago

I have nothing to add over what Neil said.

	:aceman Assignee
	Comment 13 • 10 years ago

(In reply to neil@parkwaycc.co.uk from comment #10)
> >+function CommandUpdate_Addressbook()
> ...
> >+              
> Oops?
> 
What? I copied this, but "oncommandupdate" is a real attribute. Or do you mean anything else?

	:aceman Assignee
	Comment 14 • 10 years ago

So this is a polished version, also with Seamonkey support (but untested).
I have seen just one small glitch: when contacts sidebar in compose window is opened and the first card is selected, rightclick on it shows Delete and Properties disabled. Since then, the update of the commands seems to work fine. I don't yet know what's up with that. The goDocommand("cmd_properties") IS executed even at the first click.

	neil@parkwaycc.co.uk
	Comment 15 • 10 years ago

(In reply to aceman from comment #13)
> (In reply to comment #10)
> > >+function CommandUpdate_Addressbook()
> > ...
> > >+              
> > Oops?
> > 
> What? I copied this, but "oncommandupdate" is a real attribute. Or do you
> mean anything else?

The captialisation.

	:aceman Assignee
	Comment 16 • 10 years ago

(In reply to neil@parkwaycc.co.uk from comment #15)
> (In reply to aceman from comment #13)
> > (In reply to comment #10)
> > > >+function CommandUpdate_Addressbook()
> > > ...
> > > >+              
> > > Oops?
> > > 
> > What? I copied this, but "oncommandupdate" is a real attribute. Or do you
> > mean anything else?
> 
> The captialisation.

Oh, thanks. It is messed up in more places.

	:aceman Assignee
	Comment 17 • 10 years ago

I wonder why it didn't throw or something...

	neil@parkwaycc.co.uk
	Comment 19 • 10 years ago

Comment on attachment 8438621 [details] [diff] [review]
patch v3.1

r=me on the button_edit/cmd_properties rename.

	Mike Conley (:mconley) (:⚙️)
	Comment 20 • 10 years ago

Comment on attachment 8438621 [details] [diff] [review]
patch v3.1

Review of attachment 8438621 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with this. Thanks aceman!

	:aceman Assignee
	Comment 21 • 10 years ago

Thanks.

	Magnus Melin [:mkmelin]
	Comment 22 • 10 years ago

https://hg.mozilla.org/comm-central/rev/22b623fefdd3 -> FIXED