[go: nahoru, domu]

Closed Bug 1749048 (ImageDecoder) Opened 3 years ago Closed 27 days ago

Implement ImageDecoder

Categories

(Core :: Audio/Video: Web Codecs, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: chunmin, Assigned: aosmond)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

Attachments

(2 files)

Depends on: 1730584
Depends on: VideoFrame
Depends on: 1752206
No longer depends on: 1730584
Component: Graphics: ImageLib → Audio/Video: Web Codecs

I'm happy to put this together.

Assignee: cchang → aosmond
Alias: ImageDecoder

Update, 2/3 of tests passing, patches coming soon.

Status: NEW → ASSIGNED
Type: task → enhancement

This patch adds convenience methods to throw on ErrorResult and
reject on Promise directly from a MediaResult which has an nsresult
and a message.

This leverages the promise based image decoding API added in bug
1901078 to remap that onto the WebCodecs specification.

Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b609b8fcff3
Part 1. Expose methods to throw/reject based on a MediaResult. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/0c7ce075a24f
Part 2. Implement WebCodecs image decoding API. r=webidl,media-playback-reviewers,smaug,padenot

Backed out for causing interface related mochitests failures.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces_secureContext.html | undefined: If this is failing: DANGER, are you sure you want to expose the new interface ImageDecoder to all webpages as a property of self? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

Also, please check these mochitests too.

L.E. There is also a build bustage: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&fromchange=794c0df6ca1546963aeb1eaca946129024d0f0e6&searchStr=linux%2Cx64%2Cdebug%2Chazard-linux64-haz%2Fdebug%2Ch&tochange=dab0dced4b988ff917539070a0a943f97eca274f&selectedTaskRun=Rnmr0kR_TfiwDwdTOl9YLA.0

Flags: needinfo?(aosmond)
Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6aa4e953e922
Part 1. Expose methods to throw/reject based on a MediaResult. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/40ba80bacf94
Part 2. Implement WebCodecs image decoding API. r=webidl,media-playback-reviewers,smaug,padenot

The easiest way to work around this for now is to just switch to ProcessFixedData. It incurs an extra copy but we already do it in other gfx contexts. I can do a follow up later to improve this.

Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38ee84f0cb41
Part 1. Expose methods to throw/reject based on a MediaResult. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/ad42f737c988
Part 2. Implement WebCodecs image decoding API. r=webidl,media-playback-reviewers,smaug,padenot
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: