Open
Bug 1778392
Opened 2 years ago
Updated 2 years ago
Fix narrowing conversion warnings for Imm32/Address/BaseIndex
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
ASSIGNED
People
(Reporter: iain, Assigned: iain)
Details
Attachments
(1 file)
Patches that touch masm are littered with clang-tidy warnings about implementation-defined narrowing conversions from uint32_t / size_t to int32_t when calling the Imm32/Address/BaseIndex constructors.
Assignee | ||
Comment 1•2 years ago
|
||
There were only a couple of cases where we were implicitly truncating 64-bit values, both of which were intentional.
Updated•2 years ago
|
Assignee: nobody → iireland
Status: NEW → ASSIGNED
Comment 2•2 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:iain, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Flags: needinfo?(jdemooij)
Flags: needinfo?(iireland)
Updated•2 years ago
|
Flags: needinfo?(jdemooij)
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(iireland)
You need to log in
before you can comment on or make changes to this bug.
Description
•