Support for "logout" and "delete_account" messages is missing from fx-webchannel
Categories
(Fenix :: Accounts and Sync, defect, P1)
Tracking
(firefox130 fixed)
| Tracking | Status | |
|---|---|---|
| firefox130 | --- | fixed |
People
(Reporter: mavduevskiy, Assigned: jonalmeida)
References
(Depends on 1 open bug, Blocks 3 open bugs, Regressed 1 open bug)
Details
Attachments
(4 files, 1 obsolete file)
Problem
When a user is deleting the account at "accounts.firefox.com", the app enters reath state
Solution
Listen to the webchannel message confirming account removal, and change the app state accordingly. UX should be similar to what we have on desktop.
| Reporter | ||
Updated•9 months ago
|
Comment 1•9 months ago
|
||
Updated•8 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 2•2 months ago
•
|
||
I'm going to take this since we are landing an FXA patch that would be nice to have both our platform across both of our platforms.
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 3•1 month ago
|
||
We log out from the FxaAccountManager here for the fxaccounts:logout
and fxaccounts:delete_account messages to stay in line with desktop
and [iOS][1] who the same thing today.
| Assignee | ||
Comment 4•1 month ago
|
||
This is something we want to use to make sure that the Custom Tab
intent that we received is from our own application so that we don't
mistakenly try and close an actual Custom Tab in a third party app
that has the web channel code running there.
Depends on D217156
| Assignee | ||
Comment 5•1 month ago
|
||
To connect the feature to the UI, we wrap it in an integration class
so that its isolated as we start to handle more commands.
We also early-return when we know that the shared UI is opened from
within the app instead of from a third party app.
Depends on D217158
| Assignee | ||
Comment 6•1 month ago
|
||
When adding some of these tests, we add a MainCoroutineRule which
now makes anything that was wrapped in the a Dispatchers.Main
coroutine. Since we weren't doing this before, a bunch of tests
started to fail that were not exercising the real codepaths.
Another example where we need to stop using mocks everywhere unless
it is necessary.
Depends on D217159
Pushed by jonalmeida942@gmail.com: https://hg.mozilla.org/integration/autoland/rev/50fe4f973e73 Part 1: Add support for LOGOUT and DELETE_ACCOUNT web channel messages r=chenba,android-reviewers https://hg.mozilla.org/integration/autoland/rev/e84bc1a197fc Part 2: Add Activity.isIntentInternal() for reusability r=android-reviewers,amejiamarmol https://hg.mozilla.org/integration/autoland/rev/fa0ced592e7d Part 3: Make the FxaWebChannelFeature dismiss the activity on logout r=android-reviewers,amejiamarmol https://hg.mozilla.org/integration/autoland/rev/82c5d07c2f16 Part 4: Add unit tests to FxaWebChannelFeature r=android-reviewers,amejiamarmol
https://hg.mozilla.org/mozilla-central/rev/50fe4f973e73
https://hg.mozilla.org/mozilla-central/rev/e84bc1a197fc
https://hg.mozilla.org/mozilla-central/rev/fa0ced592e7d
https://hg.mozilla.org/mozilla-central/rev/82c5d07c2f16
Description
•