jit::EliminateDeadResumePointOperands never worked as expected.
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Tracking
()
People
(Reporter: nbp, Assigned: nbp)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(2 files)
jit::EliminateDeadResumePointOperands is supposed to remove resume point operands, but the way it is implemented it removes resume point operands of resume points which are in the same block but keeps them for resume points which are in subsequent blocks, which is a non sense.
However, fixing it highlighted a set of other errors which would be fixed as dependencies of this issue.
Fixing this issue should solve the problem highlighted in Bug 1845728 comment 12.
| Assignee | ||
Comment 1•7 months ago
|
||
The prinicple of EliminateDeadResumePointOperands apparently might never
have worked, except for cases where the only resume point capturing the
values where in the same block as the instruction being captured as
operands of resume points.
This change rename the local variable to better describe what it holds
as well as fixing the logic and adding a few extra comments to better
describe the reasoning behind this optimization.
| Assignee | ||
Comment 2•7 months ago
|
||
Updated•7 months ago
|
Updated•7 months ago
|
Updated•7 months ago
|
Pushed by npierron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65b9194067b4 part 1 - Improve the BigInt tests cases to properly check the recovery path. r=iain https://hg.mozilla.org/integration/autoland/rev/7ad5c59c746b part 2 - Fix EliminateDeadResumePointOperands logic. r=iain
Comment 4•7 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/65b9194067b4
https://hg.mozilla.org/mozilla-central/rev/7ad5c59c746b
Updated•7 months ago
|
| Assignee | ||
Comment 5•7 months ago
|
||
Reopening this bug given that the part 2 has been reverted by Bug 1876978:
https://hg.mozilla.org/mozilla-central/rev/42aa41fca836
Updated•7 months ago
|
Description
•